From: Dmitry Torokhov <dtor@insightbb.com>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: linux-input@vger.kernel.org, linux-mips@linux-mips.org
Subject: Re: [PATCH] I8042: SNI RM support
Date: Wed, 16 Jan 2008 00:22:42 -0500 [thread overview]
Message-ID: <200801160022.43487.dtor@insightbb.com> (raw)
In-Reply-To: <20080112233904.4E149C2F36@solo.franken.de>
Hi Thomas,
On Saturday 12 January 2008 18:39, Thomas Bogendoerfer wrote:
> +
> +/*
> + * IRQs.
> + */
> +static int i8042_kbd_irq = -1;
> +static int i8042_aux_irq = -1;
Why initialize with -1 and not leave at 0? Or even initialize with 1/12
and override with 33/44 in i8042_platform_init()?
--
Dmitry
next prev parent reply other threads:[~2008-01-16 5:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-12 23:39 [PATCH] I8042: SNI RM support Thomas Bogendoerfer
2008-01-16 5:22 ` Dmitry Torokhov [this message]
2008-01-19 15:19 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801160022.43487.dtor@insightbb.com \
--to=dtor@insightbb.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).