From: Carlos Corbacho <carlos@strangeworlds.co.uk>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>,
linux-acpi@vger.kernel.org, Len Brown <lenb@kernel.org>,
Alexey Starikovskiy <aystarik@gmail.com>,
linux-input@vger.kernel.org
Subject: Re: [PATCH, RFC] HP WMI hotkey driver, RFKill query?
Date: Wed, 16 Jan 2008 01:38:35 +0000 [thread overview]
Message-ID: <200801160138.36347.carlos@strangeworlds.co.uk> (raw)
In-Reply-To: <20080115155215.ZZRA012@mailhub.coreip.homeip.net>
On Tuesday 15 January 2008 20:54:29 Dmitry Torokhov wrote:
> If there is a [planned] WMI sysfs device then I think input device should
> use it to form proper sysfs hierarchy. What are the roadblocks for getting
> WMI sysfs in?
The question is, would exporting the GUID virtual device and using that as the
parent make more sense? So, in the case of hp-wmi, it only uses the GUID
95F24279-4D7B-4334-9387-ACCDC67EF61C, so should we use the virtual device
associated with that GUID as the parent, or just have WMI itself as the
parent device? I'm really not sure which would be the better way to go.
Unfortunately, as you can see, a GUID is a 36 character string, which is
longer than the current 20 byte length of bus_id in a 'struct device'; so
either we have to have a temporary hack to shorten the GUID length when
creating the device, or wait for bus_id to switch to a variable length
(although it's not certain if this change will hit 2.6.25, or will be put off
until 2.6.26).
-Carlos
--
E-Mail: carlos@strangeworlds.co.uk
Web: strangeworlds.co.uk
GPG Key ID: 0x23EE722D
next prev parent reply other threads:[~2008-01-16 1:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20071218235137.12838.75397.stgit@localhost>
2007-12-26 22:48 ` [PATCH, RFC] HP WMI hotkey driver Matthew Garrett
2008-01-03 16:58 ` Dmitry Torokhov
2008-01-14 17:41 ` [PATCH, RFC] HP WMI hotkey driver, RFKill query? Matthew Garrett
2008-01-14 18:27 ` Carlos Corbacho
2008-01-14 22:25 ` Carlos Corbacho
2008-01-15 20:54 ` Dmitry Torokhov
2008-01-16 1:38 ` Carlos Corbacho [this message]
2008-01-16 1:49 ` Matthew Garrett
2008-02-07 3:54 ` Len Brown
2008-02-08 15:26 ` Carlos Corbacho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801160138.36347.carlos@strangeworlds.co.uk \
--to=carlos@strangeworlds.co.uk \
--cc=aystarik@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).