From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: fix cobalt_btns loadable keymaps support
Date: Mon, 11 Feb 2008 11:00:27 -0500 [thread overview]
Message-ID: <20080211105835.ZZRA012@mailhub.coreip.homeip.net> (raw)
In-Reply-To: <20080211215404.1c924c12.yoichi_yuasa@tripeaks.co.jp>
Hi Yoichi,
On Mon, Feb 11, 2008 at 09:54:04PM +0900, Yoichi Yuasa wrote:
> Fix cobalt_btns loadable keymaps support.
>
Thank you for the patch.
> input_set_capability(input, EV_MSC, MSC_SCAN);
> __set_bit(EV_KEY, input->evbit);
> - for (i = 0; i < ARRAY_SIZE(buttons_map); i++)
> - __set_bit(input->keycode[i], input->keybit);
> + for (i = 0; i < ARRAY_SIZE(cobalt_map); i++)
> + __set_bit(bdev->keymap[i], input->keybit);
This part is not strictly necessary since input->keycode points to
bdev->keymap. I will apply the rest of the patch.
--
Dmitry
next prev parent reply other threads:[~2008-02-11 16:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-11 12:54 [PATCH] Input: fix cobalt_btns loadable keymaps support Yoichi Yuasa
2008-02-11 16:00 ` Dmitry Torokhov [this message]
2008-02-11 17:04 ` Dmitry Torokhov
2008-02-16 9:37 ` Yoichi Yuasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080211105835.ZZRA012@mailhub.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=yoichi_yuasa@tripeaks.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).