From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH] Input: fix cobalt_btns loadable keymaps support Date: Mon, 11 Feb 2008 12:04:42 -0500 Message-ID: <20080211120409.ZZRA012@mailhub.coreip.homeip.net> References: <20080211215404.1c924c12.yoichi_yuasa@tripeaks.co.jp> <20080211105835.ZZRA012@mailhub.coreip.homeip.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from py-out-1112.google.com ([64.233.166.183]:60832 "EHLO py-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751597AbYBKREs (ORCPT ); Mon, 11 Feb 2008 12:04:48 -0500 Received: by py-out-1112.google.com with SMTP id u52so6907621pyb.10 for ; Mon, 11 Feb 2008 09:04:45 -0800 (PST) Content-Disposition: inline In-Reply-To: <20080211105835.ZZRA012@mailhub.coreip.homeip.net> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Yoichi Yuasa Cc: linux-input@vger.kernel.org On Mon, Feb 11, 2008 at 11:00:27AM -0500, Dmitry Torokhov wrote: > Hi Yoichi, > > On Mon, Feb 11, 2008 at 09:54:04PM +0900, Yoichi Yuasa wrote: > > Fix cobalt_btns loadable keymaps support. > > > > Thank you for the patch. > > > input_set_capability(input, EV_MSC, MSC_SCAN); > > __set_bit(EV_KEY, input->evbit); > > - for (i = 0; i < ARRAY_SIZE(buttons_map); i++) > > - __set_bit(input->keycode[i], input->keybit); > > + for (i = 0; i < ARRAY_SIZE(cobalt_map); i++) > > + __set_bit(bdev->keymap[i], input->keybit); > > This part is not strictly necessary since input->keycode points to > bdev->keymap. I will apply the rest of the patch. > Oh, I see now... The controlling condition is the loop was incorrect. -- Dmitry