From: Samuel Ortiz <sameo@openedhand.com>
To: linux-input@vger.kernel.org, dmitry.torokhov@gmail.com
Cc: Eric Miao <eric.miao@marvell.com>
Subject: [PATCH] Fix pxa27x keypad KPC macros
Date: Tue, 19 Feb 2008 11:25:12 +0100 [thread overview]
Message-ID: <20080219102511.GA6396@caravaggio> (raw)
Hi Dmitry,
On the pxa27x keypad driver, we want to mask (key_number - 1), not
key_number.
The current implementation works fine for all values but the maximum
one, i.e. 8.
This patch is against your input git tree.
Signed-off-by: Samuel Ortiz <sameo@openedhand.com>
---
drivers/input/keyboard/pxa27x_keypad.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Index: linux-2.6-input/drivers/input/keyboard/pxa27x_keypad.c
===================================================================
--- linux-2.6-input.orig/drivers/input/keyboard/pxa27x_keypad.c 2008-02-19 11:10:04.000000000 +0100
+++ linux-2.6-input/drivers/input/keyboard/pxa27x_keypad.c 2008-02-19 11:11:00.000000000 +0100
@@ -50,9 +50,9 @@
#define KPKDI 0x0048
/* bit definitions */
-#define KPC_MKRN(n) ((((n) & 0x7) - 1) << 26) /* matrix key row number */
-#define KPC_MKCN(n) ((((n) & 0x7) - 1) << 23) /* matrix key column number */
-#define KPC_DKN(n) ((((n) & 0x7) - 1) << 6) /* direct key number */
+#define KPC_MKRN(n) ((((n) - 1) & 0x7) << 26) /* matrix key row number */
+#define KPC_MKCN(n) ((((n) - 1) & 0x7) << 23) /* matrix key column number */
+#define KPC_DKN(n) ((((n) - 1) & 0x7) << 6) /* direct key number */
#define KPC_AS (0x1 << 30) /* Automatic Scan bit */
#define KPC_ASACT (0x1 << 29) /* Automatic Scan on Activity */
next reply other threads:[~2008-02-19 10:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-19 10:25 Samuel Ortiz [this message]
2008-03-20 7:02 ` [PATCH] Fix pxa27x keypad KPC macros eric miao
[not found] ` <E913911567467945BBEB9277E27868B088127A@msiexch01.marvell.com>
2008-03-20 13:49 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080219102511.GA6396@caravaggio \
--to=sameo@openedhand.com \
--cc=dmitry.torokhov@gmail.com \
--cc=eric.miao@marvell.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).