* [patch 2.6.25-rc3] omap-keypad buildfix
@ 2008-02-25 3:14 David Brownell
2008-02-29 15:59 ` Tony Lindgren
0 siblings, 1 reply; 2+ messages in thread
From: David Brownell @ 2008-02-25 3:14 UTC (permalink / raw)
To: linux-input, linux-omap
Build fixes:
drivers/input/keyboard/omap-keypad.c: In function 'omap_kp_probe':
drivers/input/keyboard/omap-keypad.c:418: warning: 'row_idx' is used uninitialized in this function
drivers/input/keyboard/omap-keypad.c:421: warning: 'col_idx' is used uninitialized in this function
These variables are useful when cpu_is_omap24xx(), and otherwise just
for probe() cleanup.
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
---
The OMAP tree has the same bug.
drivers/input/keyboard/omap-keypad.c | 3 +++
1 files changed, 3 insertions(+)
--- a/drivers/input/keyboard/omap-keypad.c 2008-02-24 18:50:32.000000000 -0800
+++ b/drivers/input/keyboard/omap-keypad.c 2008-02-24 19:10:17.000000000 -0800
@@ -352,6 +352,9 @@ static int __init omap_kp_probe(struct p
}
omap_set_gpio_direction(row_gpios[row_idx], 1);
}
+ } else {
+ col_idx = 0;
+ row_idx = 0;
}
setup_timer(&omap_kp->timer, omap_kp_timer, (unsigned long)omap_kp);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch 2.6.25-rc3] omap-keypad buildfix
2008-02-25 3:14 [patch 2.6.25-rc3] omap-keypad buildfix David Brownell
@ 2008-02-29 15:59 ` Tony Lindgren
0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2008-02-29 15:59 UTC (permalink / raw)
To: David Brownell; +Cc: linux-input, linux-omap
* David Brownell <david-b@pacbell.net> [080224 19:14]:
> Build fixes:
>
> drivers/input/keyboard/omap-keypad.c: In function 'omap_kp_probe':
> drivers/input/keyboard/omap-keypad.c:418: warning: 'row_idx' is used uninitialized in this function
> drivers/input/keyboard/omap-keypad.c:421: warning: 'col_idx' is used uninitialized in this function
>
> These variables are useful when cpu_is_omap24xx(), and otherwise just
> for probe() cleanup.
>
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
> ---
> The OMAP tree has the same bug.
>
> drivers/input/keyboard/omap-keypad.c | 3 +++
> 1 files changed, 3 insertions(+)
>
> --- a/drivers/input/keyboard/omap-keypad.c 2008-02-24 18:50:32.000000000 -0800
> +++ b/drivers/input/keyboard/omap-keypad.c 2008-02-24 19:10:17.000000000 -0800
> @@ -352,6 +352,9 @@ static int __init omap_kp_probe(struct p
> }
> omap_set_gpio_direction(row_gpios[row_idx], 1);
> }
> + } else {
> + col_idx = 0;
> + row_idx = 0;
> }
>
> setup_timer(&omap_kp->timer, omap_kp_timer, (unsigned long)omap_kp);
Pushing today.
Tony
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-02-29 16:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-25 3:14 [patch 2.6.25-rc3] omap-keypad buildfix David Brownell
2008-02-29 15:59 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).