From: Pete Zaitcev <zaitcev@redhat.com>
To: linux-input@vger.kernel.org
Cc: zaitcev@redhat.com
Subject: Patch for oops in a grabbed evdev after disconnect
Date: Mon, 17 Mar 2008 23:48:07 -0700 [thread overview]
Message-ID: <20080317234807.42c72a76.zaitcev@redhat.com> (raw)
If a device was grabbed through evdev and then became disconnected,
we oops on close. This happens because input_release_device uses memory
which was freed.
Fedora enabled evdev in X11 by default recently, and now anyone who
flips a KVM oopses when they log out (Fedora bug 436659).
Signed-off-by: Pete Zaitcev <zaitcev@redhat.com>
diff --git a/drivers/input/evdev.c b/drivers/input/evdev.c
index 0727b0a..c0874a3 100644
--- a/drivers/input/evdev.c
+++ b/drivers/input/evdev.c
@@ -155,7 +155,8 @@ static int evdev_ungrab(struct evdev *evdev, struct evdev_client *client)
rcu_assign_pointer(evdev->grab, NULL);
synchronize_rcu();
- input_release_device(&evdev->handle);
+ if (evdev->exist)
+ input_release_device(&evdev->handle);
return 0;
}
next reply other threads:[~2008-03-18 6:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-18 6:48 Pete Zaitcev [this message]
2008-03-18 13:31 ` Patch for oops in a grabbed evdev after disconnect Dmitry Torokhov
2008-03-18 18:03 ` Pete Zaitcev
2008-03-18 18:54 ` Dmitry Torokhov
2008-03-21 17:51 ` Pete Zaitcev
2008-04-08 17:41 ` Pete Zaitcev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080317234807.42c72a76.zaitcev@redhat.com \
--to=zaitcev@redhat.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).