From: Magnus Damm <magnus.damm@gmail.com>
To: linux-input@vger.kernel.org
Cc: Magnus Damm <magnus.damm@gmail.com>,
lethal@linux-sh.org, dmitry.torokhov@gmail.com,
akpm@linux-foundation.org, linux-sh@vger.kernel.org
Subject: [PATCH] Fix sh_keysc double free
Date: Fri, 21 Mar 2008 20:14:46 +0900 [thread overview]
Message-ID: <20080321111446.13134.8863.sendpatchset@rx1.opensource.se> (raw)
Avoid double free situation from happening by removing input_free_device()
after input_unregister_device(). Suggested by Dmitry Torokhov.
Signed-off-by: Magnus Damm <damm@igel.co.jp>
---
drivers/input/keyboard/sh_keysc.c | 1 -
1 file changed, 1 deletion(-)
--- 0001/drivers/input/keyboard/sh_keysc.c
+++ work/drivers/input/keyboard/sh_keysc.c 2008-03-21 10:58:20.000000000 +0900
@@ -238,7 +238,6 @@ static int __devexit sh_keysc_remove(str
input_unregister_device(priv->input);
free_irq(platform_get_irq(pdev, 0), pdev);
- input_free_device(priv->input);
iounmap(priv->iomem_base);
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
next reply other threads:[~2008-03-21 11:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-21 11:14 Magnus Damm [this message]
2008-03-24 6:13 ` [PATCH] Fix sh_keysc double free Paul Mundt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080321111446.13134.8863.sendpatchset@rx1.opensource.se \
--to=magnus.damm@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dmitry.torokhov@gmail.com \
--cc=lethal@linux-sh.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).