Linux Input/HID development
 help / color / mirror / Atom feed
From: Oliver Neukum <oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
To: Jiri Kosina <jkosina-AlSwsSmVLrQ@public.gmane.org>
Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [patch]race between open and disconnect in usbhid
Date: Mon, 31 Mar 2008 16:25:43 +0200	[thread overview]
Message-ID: <200803311625.43803.oliver@neukum.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0803311534240.5541-YCXOAqNspd+N3ZZ/Hiejyg@public.gmane.org>

Am Montag, 31. März 2008 15:35:15 schrieb Jiri Kosina:
> On Mon, 31 Mar 2008, Oliver Neukum wrote:
> 
> > > > + char disconnected:1;                                            /* indicates undead device - no use */
> > > Wouldn't introduction of new flag (HID_DISCONNECTED) to 
> > > usbhid_device->iofl be cleaner?
> > A matter of taste. I don't use atomic ops if I don't have to, but if you
> > like it better the other way I can redo it.
> 
> I would really appreciate that, thanks. It really reflects the status of 
> the device with respect to the I/O in a very similar way as other I/O 
> flags, so we should keep it together if possible.

Done.

	Regards
		Oliver

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2008-03-31 14:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-31 13:35 [patch]race between open and disconnect in usbhid Oliver Neukum
2008-03-31 13:23 ` Jiri Kosina
2008-03-31 13:47   ` Oliver Neukum
     [not found]     ` <200803311547.56448.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
2008-03-31 13:35       ` Jiri Kosina
     [not found]         ` <Pine.LNX.4.64.0803311534240.5541-YCXOAqNspd+N3ZZ/Hiejyg@public.gmane.org>
2008-03-31 14:25           ` Oliver Neukum [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200803311625.43803.oliver@neukum.org \
    --to=oliver-gvhc2dphhpqdnm+yrofe0a@public.gmane.org \
    --cc=jkosina-AlSwsSmVLrQ@public.gmane.org \
    --cc=linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox