From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Tobias M?ller <Tobias_Mueller@twam.info>, linux-input@vger.kernel.org
Subject: Re: [PATCH] appletouch driver and 4th generation macbooks
Date: Wed, 2 Apr 2008 10:19:47 -0400 [thread overview]
Message-ID: <20080402101704.ZZRA012@mailhub.coreip.homeip.net> (raw)
In-Reply-To: <1207135383.10910.39.camel@johannes.berg>
Hi Johannes, Tobias,
On Wed, Apr 02, 2008 at 01:23:03PM +0200, Johannes Berg wrote:
>
> On Wed, 2008-04-02 at 13:16 +0200, Tobias M??ller wrote:
> > Hi,
> >
> > Johannes Berg schrieb:
> > >> Adds product ids for 4th generation MacBooks in appletouch driver.
> > >
> > > Looks good.
> > >
> > >> Signed-off-by: Tobias Mueller <Tobias_Mueller@twam.info>
> > >
> > > Acked-by: Johannes Berg <johannes@sipsolutions.net>
> >
> > I still cannot find the new device ids in 2.6.25-rc8. Is there anything to do further from my side?
>
> I guess I was supposed to pick up the patch and thought somebody else
> would. Dmitry, can you pick it up into your input tree?
>
> I don't expect it to be going into 2.6.25 at this point, it's rather
> close to being released. On the other hand, it's not like it can cause
> regressions, but I guess we need to draw a line at some point.
>
I applied the patch to my tree. I will try to push the change to Linus
before 2.6.25 since it is very low risk. Btw, is_geyser3() function
is becoming unwieldy. We might consider changing it to something that
scans array of integers instead of adding more conditions to that "if"
statement next time we add more IDs to it.
--
Dmitry
next prev parent reply other threads:[~2008-04-02 14:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-14 17:22 [PATCH] appletouch driver and 4th generation macbooks Tobias Müller
2008-03-15 13:46 ` Johannes Berg
2008-03-16 10:48 ` Tobias Müller
2008-03-16 11:02 ` Johannes Berg
2008-04-02 11:16 ` Tobias Müller
2008-04-02 11:23 ` Johannes Berg
2008-04-02 14:19 ` Dmitry Torokhov [this message]
2008-04-03 10:08 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080402101704.ZZRA012@mailhub.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=Tobias_Mueller@twam.info \
--cc=johannes@sipsolutions.net \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).