* [patch]unnecessary GFP_ATOMIC in xpad driver
@ 2008-04-03 11:50 Oliver Neukum
[not found] ` <200804031350.16684.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Oliver Neukum @ 2008-04-03 11:50 UTC (permalink / raw)
To: jikos-AlSwsSmVLrQ, honza-wDf7oJUeT2I,
linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-input-u79uwXL29TY76Z2rM5mHXA
GFP_ATOMIC should not be used when GFP_KERNEL can be used.
Signed-off-by: Oliver Neukum <oneukum-l3A5Bk7waGM@public.gmane.org>
---
--- linux-2.6.25-rc7-work/drivers/input/joystick/xpad.c.2 2008-04-03 13:29:55.000000000 +0200
+++ linux-2.6.25-rc7-work/drivers/input/joystick/xpad.c 2008-04-03 13:30:01.000000000 +0200
@@ -412,7 +412,7 @@ static int xpad_init_output(struct usb_i
return 0;
xpad->odata = usb_buffer_alloc(xpad->udev, XPAD_PKT_LEN,
- GFP_ATOMIC, &xpad->odata_dma );
+ GFP_KERNEL, &xpad->odata_dma );
if (!xpad->odata)
goto fail1;
@@ -636,7 +636,7 @@ static int xpad_probe(struct usb_interfa
goto fail1;
xpad->idata = usb_buffer_alloc(udev, XPAD_PKT_LEN,
- GFP_ATOMIC, &xpad->idata_dma);
+ GFP_KERNEL, &xpad->idata_dma);
if (!xpad->idata)
goto fail1;
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-04-03 20:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-03 11:50 [patch]unnecessary GFP_ATOMIC in xpad driver Oliver Neukum
[not found] ` <200804031350.16684.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
2008-04-03 20:23 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).