linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pete Zaitcev <zaitcev@redhat.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, dwmw2@redhat.com
Subject: Re: Patch for oops in a grabbed evdev after disconnect
Date: Tue, 8 Apr 2008 10:41:53 -0700	[thread overview]
Message-ID: <20080408104153.33c74b97.zaitcev@redhat.com> (raw)
In-Reply-To: <20080318144432.ZZRA012@mailhub.coreip.homeip.net>

On Tue, 18 Mar 2008 14:54:17 -0400, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:

> > > [] As far as I understand the
> > > the input_dev structure shold be pinned in memory by the driver
> > > core since we have this link:
> > > 
> > > 	evdev->dev.parent = &input_dev->dev;

> > I don't think anyone checks this, unless the accompaining refcount
> > is set.

> From what I see we should be automatically taking the reference
> to parent kobject in
> 
> kobject_add_internal():
> 	parent = kobject_get(kobj->parent);
> 
> perent is set in kobject_add_varg():
> 	kobj->parent = parent;

I see you fixed this in a7097ff89c3204737a07eecbc83f9ae6002cc534.
Adam Jackson reports on the X11 side that it worked.

-- Pete

      parent reply	other threads:[~2008-04-08 17:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-18  6:48 Patch for oops in a grabbed evdev after disconnect Pete Zaitcev
2008-03-18 13:31 ` Dmitry Torokhov
2008-03-18 18:03   ` Pete Zaitcev
2008-03-18 18:54     ` Dmitry Torokhov
2008-03-21 17:51       ` Pete Zaitcev
2008-04-08 17:41       ` Pete Zaitcev [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080408104153.33c74b97.zaitcev@redhat.com \
    --to=zaitcev@redhat.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=dwmw2@redhat.com \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).