From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Jiri Kosina <jkosina@suse.cz>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] wm97xx-core: Only schedule interrupt handler if not already scheduled
Date: Mon, 14 Apr 2008 14:10:02 -0400 [thread overview]
Message-ID: <20080414140832.ZZRA012@mailhub.coreip.homeip.net> (raw)
In-Reply-To: <1208194775-4293-1-git-send-email-broonie@opensource.wolfsonmicro.com>
Hi Mark,
On Mon, Apr 14, 2008 at 06:39:33PM +0100, Mark Brown wrote:
> static irqreturn_t wm97xx_pen_interrupt(int irq, void *dev_id)
> {
> struct wm97xx *wm = dev_id;
>
> - wm->mach_ops->irq_enable(wm, 0);
> - queue_work(wm->ts_workq, &wm->pen_event_work);
> + if (!work_pending(&wm->pen_event_work)) {
> + wm->mach_ops->irq_enable(wm, 0);
> + queue_work(wm->ts_workq, &wm->pen_event_work);
> + }
Given the fact that work will not be queued if it is pending anyway
why is this change needed?
--
Dmitry
next prev parent reply other threads:[~2008-04-14 18:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-14 17:38 WM97xx touchscreen updates Mark Brown
2008-04-14 17:39 ` [PATCH 1/3] wm97xx-core: Only schedule interrupt handler if not already scheduled Mark Brown
2008-04-14 17:39 ` [PATCH 2/3] wm97xx-core: Use IRQF_SAMPLE_RANDOM Mark Brown
2008-04-14 17:39 ` [PATCH 3/3] wm97xx-core: Support use as a wakeup source Mark Brown
2008-04-14 20:34 ` Dmitry Torokhov
2008-04-15 0:29 ` David Brownell
2008-04-15 12:18 ` Mark Brown
2008-04-14 18:10 ` Dmitry Torokhov [this message]
2008-04-15 8:48 ` [PATCH 1/3] wm97xx-core: Only schedule interrupt handler if not already scheduled Mark Brown
2008-04-15 13:02 ` Dmitry Torokhov
2008-04-15 14:42 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2008-04-15 14:45 WM97xx touchscreen updates Mark Brown
2008-04-15 14:47 ` [PATCH 1/3] wm97xx-core: Only schedule interrupt handler if not already scheduled Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080414140832.ZZRA012@mailhub.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).