* [RESEND patch 2.6.25-rc8] gpio_keys irq handling
@ 2008-04-11 7:35 David Brownell
2008-04-15 5:37 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: David Brownell @ 2008-04-11 7:35 UTC (permalink / raw)
To: dmitry.torokhov, linux-input, linux-input; +Cc: Jiri Kosina, Phil Blundell
From: David Brownell <dbrownell@users.sourceforge.net>
Cleanup IRQ handling in gpio_keys: bail after handling the IRQ, and
report IRQ_NONE if we never handle it.
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Cc: Phil Blundell <pb@handhelds.org>
Cc: Dmitry Torokhov <dtor@mail.ru>
---
No functional changes since the version sent 27-Dec-2007.
MAINTAINERS says "linux-input@vger" but the only archives
I could find seems to say "@atrey.karlin.mff.cuni.cz"...
drivers/input/keyboard/gpio_keys.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- g26.orig/drivers/input/keyboard/gpio_keys.c 2008-04-10 19:39:15.000000000 -0700
+++ g26/drivers/input/keyboard/gpio_keys.c 2008-04-11 00:30:45.000000000 -0700
@@ -43,10 +43,11 @@ static irqreturn_t gpio_keys_isr(int irq
input_event(input, type, button->code, !!state);
input_sync(input);
+ return IRQ_HANDLED;
}
}
- return IRQ_HANDLED;
+ return IRQ_NONE;
}
static int __devinit gpio_keys_probe(struct platform_device *pdev)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [RESEND patch 2.6.25-rc8] gpio_keys irq handling
2008-04-11 7:35 [RESEND patch 2.6.25-rc8] gpio_keys irq handling David Brownell
@ 2008-04-15 5:37 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2008-04-15 5:37 UTC (permalink / raw)
To: David Brownell; +Cc: linux-input, linux-input, Jiri Kosina, Phil Blundell
On Fri, Apr 11, 2008 at 12:35:55AM -0700, David Brownell wrote:
> From: David Brownell <dbrownell@users.sourceforge.net>
>
> Cleanup IRQ handling in gpio_keys: bail after handling the IRQ, and
> report IRQ_NONE if we never handle it.
>
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
> Cc: Phil Blundell <pb@handhelds.org>
> Cc: Dmitry Torokhov <dtor@mail.ru>
Applied, thank you David.
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-04-15 5:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-11 7:35 [RESEND patch 2.6.25-rc8] gpio_keys irq handling David Brownell
2008-04-15 5:37 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).