[PATCH] xpad - Set buffer length for outgoing requests

[PATCH] xpad - Set buffer length for outgoing requests

[Michael Gruber]

From: Michael Gruber <lists.mg@googlemail.com>

The messages for led/rumble are exactly 3 and 8 bytes respectively.
Hence set up the transfer_buffer_length accordingly.

Signed-off-by: Michael Gruber <lists.mg@googlemail.com>

---

Hi, my Xbox360 Controller will not work at all unless this is set up correctly.
I am new to linux kernel programming and would appreciate any kinds of comments.

 drivers/input/joystick/xpad.c |    2 ++
 1 file changed, 2 insertions(+)

--- a/drivers/input/joystick/xpad.c	2008-04-05 15:18:37.000000000 +0200
+++ b/drivers/input/joystick/xpad.c	2008-04-05 15:18:25.000000000 +0200
@@ -558,6 +558,7 @@ static int xpad_play_effect(struct input
 		xpad->odata[5] = 0x00;
 		xpad->odata[6] = 0x00;
 		xpad->odata[7] = 0x00;
+		xpad->irq_out->transfer_buffer_length = 8;
 		usb_submit_urb(xpad->irq_out, GFP_KERNEL);
 	}

@@ -594,6 +595,7 @@ static void xpad_send_led_command(struct
 		xpad->odata[0] = 0x01;
 		xpad->odata[1] = 0x03;
 		xpad->odata[2] = command;
+		xpad->irq_out->transfer_buffer_length = 3;
 		usb_submit_urb(xpad->irq_out, GFP_KERNEL);
 		mutex_unlock(&xpad->odata_mutex);
 	}

Re: [PATCH] xpad - Set buffer length for outgoing requests

[Dmitry Torokhov]

Hi Michael,

On Tue, Apr 08, 2008 at 01:05:27PM +0200, Michael Gruber wrote:
> From: Michael Gruber <lists.mg@googlemail.com>
> 
> The messages for led/rumble are exactly 3 and 8 bytes respectively.
> Hence set up the transfer_buffer_length accordingly.
> 
> Signed-off-by: Michael Gruber <lists.mg@googlemail.com>
> 

Thank you for the patch, it seems reasonable. Anssi, any objections?

> ---
> 
> Hi, my Xbox360 Controller will not work at all unless this is set up correctly.
> I am new to linux kernel programming and would appreciate any kinds of comments.
> 
>  drivers/input/joystick/xpad.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> --- a/drivers/input/joystick/xpad.c	2008-04-05 15:18:37.000000000 +0200
> +++ b/drivers/input/joystick/xpad.c	2008-04-05 15:18:25.000000000 +0200
> @@ -558,6 +558,7 @@ static int xpad_play_effect(struct input
>  		xpad->odata[5] = 0x00;
>  		xpad->odata[6] = 0x00;
>  		xpad->odata[7] = 0x00;
> +		xpad->irq_out->transfer_buffer_length = 8;
>  		usb_submit_urb(xpad->irq_out, GFP_KERNEL);
>  	}
> 
> @@ -594,6 +595,7 @@ static void xpad_send_led_command(struct
>  		xpad->odata[0] = 0x01;
>  		xpad->odata[1] = 0x03;
>  		xpad->odata[2] = command;
> +		xpad->irq_out->transfer_buffer_length = 3;
>  		usb_submit_urb(xpad->irq_out, GFP_KERNEL);
>  		mutex_unlock(&xpad->odata_mutex);
>  	}

-- 
Dmitry

Re: [PATCH] xpad - Set buffer length for outgoing requests

[Anssi Hannula]

Dmitry Torokhov wrote:
> Hi Michael,
> 
> On Tue, Apr 08, 2008 at 01:05:27PM +0200, Michael Gruber wrote:
>> From: Michael Gruber <lists.mg@googlemail.com>
>>
>> The messages for led/rumble are exactly 3 and 8 bytes respectively.
>> Hence set up the transfer_buffer_length accordingly.
>>
>> Signed-off-by: Michael Gruber <lists.mg@googlemail.com>
>>
> 
> Thank you for the patch, it seems reasonable. Anssi, any objections?

Seems ok, though I'm not a urb expert.

Acked-by: Anssi Hannula <anssi.hannula@gmail.com>

>> ---
>>
>> Hi, my Xbox360 Controller will not work at all unless this is set up correctly.
>> I am new to linux kernel programming and would appreciate any kinds of comments.
>>
>>  drivers/input/joystick/xpad.c |    2 ++
>>  1 file changed, 2 insertions(+)
>>
>> --- a/drivers/input/joystick/xpad.c	2008-04-05 15:18:37.000000000 +0200
>> +++ b/drivers/input/joystick/xpad.c	2008-04-05 15:18:25.000000000 +0200
>> @@ -558,6 +558,7 @@ static int xpad_play_effect(struct input
>>  		xpad->odata[5] = 0x00;
>>  		xpad->odata[6] = 0x00;
>>  		xpad->odata[7] = 0x00;
>> +		xpad->irq_out->transfer_buffer_length = 8;
>>  		usb_submit_urb(xpad->irq_out, GFP_KERNEL);
>>  	}
>>
>> @@ -594,6 +595,7 @@ static void xpad_send_led_command(struct
>>  		xpad->odata[0] = 0x01;
>>  		xpad->odata[1] = 0x03;
>>  		xpad->odata[2] = command;
>> +		xpad->irq_out->transfer_buffer_length = 3;
>>  		usb_submit_urb(xpad->irq_out, GFP_KERNEL);
>>  		mutex_unlock(&xpad->odata_mutex);
>>  	}
> 


-- 
Anssi Hannula

Re: [PATCH] xpad - Set buffer length for outgoing requests

[Dmitry Torokhov]

On Sat, Apr 12, 2008 at 09:14:28AM +0300, Anssi Hannula wrote:
> Dmitry Torokhov wrote:
> > Hi Michael,
> > 
> > On Tue, Apr 08, 2008 at 01:05:27PM +0200, Michael Gruber wrote:
> >> From: Michael Gruber <lists.mg@googlemail.com>
> >>
> >> The messages for led/rumble are exactly 3 and 8 bytes respectively.
> >> Hence set up the transfer_buffer_length accordingly.
> >>
> >> Signed-off-by: Michael Gruber <lists.mg@googlemail.com>
> >>
> > 
> > Thank you for the patch, it seems reasonable. Anssi, any objections?
> 
> Seems ok, though I'm not a urb expert.
> 
> Acked-by: Anssi Hannula <anssi.hannula@gmail.com>
> 

We do the similar manipulations in other drivers...

Applied, thank you Michael.

-- 
Dmitry