From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Ville Syrj?l? <syrjala@sci.fi>
Cc: Peter Stokes <linux@dadeos.co.uk>,
linux-input@vger.kernel.org, Jiri Kosina <jkosina@suse.cz>
Subject: Re: [PATCH] ati_remote2 loadable keymap support
Date: Thu, 17 Apr 2008 15:00:23 -0400 [thread overview]
Message-ID: <20080417144328.ZZRA012@mailhub.coreip.homeip.net> (raw)
In-Reply-To: <20080408201826.GG16619@sci.fi>
On Tue, Apr 08, 2008 at 11:18:26PM +0300, Ville Syrj?l? wrote:
> On Sat, Apr 05, 2008 at 07:30:10PM +0100, Peter Stokes wrote:
> > + u8 hwcode;
> > + u16 keycode[ARRAY_SIZE(ati_remote2_modes)];
> > +} ati_remote2_keycodes[] = {
> > +/* hwcode AUX1 AUX2 AUX3 AUX4 PC */
>
> checkpatch.pl doesn't like these long lines.
>
In this case screw checkpatch, sometimes longer lines are better than
the alternative.
Peter, is an updated patch addressing other Ville's concerns coming?
--
Dmitry
next prev parent reply other threads:[~2008-04-17 19:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-05 18:30 [PATCH] ati_remote2 loadable keymap support Peter Stokes
2008-04-08 20:18 ` Ville Syrjälä
2008-04-17 19:00 ` Dmitry Torokhov [this message]
2008-04-18 20:49 ` Peter Stokes
2008-04-18 19:42 ` Peter Stokes
2008-06-03 18:45 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080417144328.ZZRA012@mailhub.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux@dadeos.co.uk \
--cc=syrjala@sci.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).