From: Dmitry Torokhov <dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Bryan Wu <cooloney-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: andre-uV3PkZocewMvJ4zyQN8m6A@public.gmane.org,
Michael Hennerich
<michael.hennerich-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org>,
vapier.adi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org,
linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/1] Input/Joystick Driver: add support AD7142 joystick driver (v2)
Date: Fri, 18 Apr 2008 13:15:58 -0400 [thread overview]
Message-ID: <20080418131149.ZZRA012@mailhub.coreip.homeip.net> (raw)
In-Reply-To: <1206643110-8789-1-git-send-email-cooloney-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Hi Bryan,
On Thu, Mar 27, 2008 at 11:38:30AM -0700, Bryan Wu wrote:
> + input->keybit[BIT_WORD(BTN_BASE)] = BIT_MASK(BTN_BASE) |
> + BIT_MASK(BTN_BASE2) |
> + BIT_MASK(BTN_BASE3) |
> + BIT_MASK(BTN_BASE4);
> + input->keybit[BIT_WORD(KEY_UP)] |= BIT_MASK(KEY_UP) |
> + BIT_MASK(KEY_DOWN) |
> + BIT_MASK(KEY_LEFT) |
> + BIT_MASK(KEY_RIGHT);
> +
Why don't you use REL_X/REL_Y to report directional movement? Using
buttons for that is pretty unusual.
--
Dmitry
_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c
next prev parent reply other threads:[~2008-04-18 17:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-27 18:38 [PATCH 1/1] Input/Joystick Driver: add support AD7142 joystick driver (v2) Bryan Wu
[not found] ` <1206643110-8789-1-git-send-email-cooloney-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2008-04-18 17:15 ` Dmitry Torokhov [this message]
2008-04-25 10:09 ` Bryan Wu
2008-04-25 15:39 ` Dmitry Torokhov
2008-04-27 1:09 ` [PATCH 1/1] Input/Joystick Driver: add support AD7142 joystickdriver (v2) Robin Getz
2008-04-27 13:52 ` [PATCH 1/1] Input/Joystick Driver: add support AD7142 joystick driver (v2) Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080418131149.ZZRA012@mailhub.coreip.homeip.net \
--to=dmitry.torokhov-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=andre-uV3PkZocewMvJ4zyQN8m6A@public.gmane.org \
--cc=cooloney-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org \
--cc=linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=michael.hennerich-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org \
--cc=vapier.adi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).