linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Dag Bakke <dag@bakke.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	Jiri Kosina <jkosina@suse.cz>,
	Diego 'Flameeyes' Petteno <flameeyes@gmail.com>
Subject: Re: [PATCH] fix apple alu keyboard with numpad
Date: Thu, 8 May 2008 18:42:55 +0100	[thread overview]
Message-ID: <20080508174255.GA8136@srcf.ucam.org> (raw)
In-Reply-To: <4823386A.6000501@bakke.com>

On Thu, May 08, 2008 at 07:29:14PM +0200, Dag Bakke wrote:
> Matthew Garrett wrote, On 05/07/2008 01:43 AM:
> >On Tue, May 06, 2008 at 12:54:06PM -0700, Andrew Morton wrote:
> >
> >>>-static int hid_apple_fnmode = 1;
> >>>+static int hid_apple_fnmode = 2;
> >
> >Regardless of anything else, we don't want this hunk.
> >
> 
> Was my reasoning for this change off ("F-keys used more often that 
> multimediakeys, ergo make that the default"), or is your resistance to 
> this change due to some kind of policy?

It's a change in behaviour of a wide range of keyboards, and it's in a 
patch that is supposed to be fixing a single keyboard. Personally, I 
suspect that the people who are going to want the F-keys by default are 
the people who are easily able to change this behaviour and the ones who 
aren't are the ones who are going to expect their keyboard to behave 
like it did under MacOS. But that's a separate argument for a separate 
patch :)

-- 
Matthew Garrett | mjg59@srcf.ucam.org

      reply	other threads:[~2008-05-08 17:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-27 11:19 [PATCH] fix apple alu keyboard with numpad Dag Bakke
2008-05-06 19:54 ` Andrew Morton
2008-05-06 20:46   ` Jiri Kosina
2008-05-08 17:24     ` Dag Bakke
2008-05-11 22:54       ` Jiri Kosina
2008-05-12  7:45         ` Dag Bakke
2008-05-06 23:43   ` Matthew Garrett
2008-05-08 17:29     ` Dag Bakke
2008-05-08 17:42       ` Matthew Garrett [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080508174255.GA8136@srcf.ucam.org \
    --to=mjg59@srcf.ucam.org \
    --cc=akpm@linux-foundation.org \
    --cc=dag@bakke.com \
    --cc=flameeyes@gmail.com \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).