From: Tino Keitel <tino.keitel@gmx.de>
To: Greg KH <greg@kroah.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
jkosina@suse.cz, linux-input@vger.kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: add appleir USB driver
Date: Thu, 15 May 2008 15:21:08 +0200 [thread overview]
Message-ID: <20080515132108.GA9327@dose.home.local> (raw)
In-Reply-To: <20080514221519.GA6575@kroah.com>
On Wed, May 14, 2008 at 15:15:19 -0700, Greg KH wrote:
> From: Greg Kroah-Hartman <gregkh@suse.de>
>
> This driver was originally written by James McKenzie but forward ported
> and cleaned up by me to get it to work with modern kernel versions.
>
> Tested on my mac mini and it actually works!
>
> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
>
> ---
>
> Jiri, is it ok for this quirks addtion to go through Dmitry's triee? Or
> do you want me to split it out into two different patches?
>
> Dmitry, is this ok to go through your tree? Or I can take it as well if
> you don't want it :)
>
> drivers/hid/usbhid/hid-quirks.c | 2
> drivers/input/misc/Kconfig | 12 +
> drivers/input/misc/Makefile | 1
> drivers/input/misc/appleir.c | 361 ++++++++++++++++++++++++++++++++++++++++
> 4 files changed, 376 insertions(+)
>
> --- a/drivers/hid/usbhid/hid-quirks.c
> +++ b/drivers/hid/usbhid/hid-quirks.c
> @@ -77,6 +77,7 @@
> #define USB_DEVICE_ID_APPLE_ALU_WIRELESS_JIS 0x022e
> #define USB_DEVICE_ID_APPLE_FOUNTAIN_TP_ONLY 0x030a
> #define USB_DEVICE_ID_APPLE_GEYSER1_TP_ONLY 0x030b
> +#define USB_DEVICE_ID_APPLE_IRCONTROL 0x8240
> #define USB_DEVICE_ID_APPLE_IRCONTROL4 0x8242
>
> #define USB_VENDOR_ID_ASUS 0x0b05
> @@ -443,6 +444,7 @@ static const struct hid_blacklist {
> { USB_VENDOR_ID_AFATECH, USB_DEVICE_ID_AFATECH_AF9016, HID_QUIRK_FULLSPEED_INTERVAL },
>
> { USB_VENDOR_ID_BELKIN, USB_DEVICE_ID_FLIP_KVM, HID_QUIRK_HIDDEV },
> + { USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_IRCONTROL, HID_QUIRK_IGNORE },
> { USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_IRCONTROL4, HID_QUIRK_HIDDEV | HID_QUIRK_IGNORE_HIDINPUT },
> { USB_VENDOR_ID_SAMSUNG, USB_DEVICE_ID_SAMSUNG_IR_REMOTE, HID_QUIRK_HIDDEV | HID_QUIRK_IGNORE_HIDINPUT },
> { USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_SIDEWINDER_GV, HID_QUIRK_HIDINPUT },
Hi,
I'm pretty sure that this breaks the macmini LIRC driver again, see
commit 3e1928e8793208802589aae851b6685671187242.
Regards,
Tino
next prev parent reply other threads:[~2008-05-15 13:21 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-14 22:15 [PATCH] Input: add appleir USB driver Greg KH
2008-05-14 23:27 ` Matthew Garrett
2008-05-14 23:49 ` Greg KH
2008-05-15 6:20 ` Sitsofe Wheeler
2008-05-15 3:50 ` Dmitry Torokhov
2008-05-15 13:21 ` Tino Keitel [this message]
[not found] ` <20080515132108.GA9327-z7fNteJZwjmqk56C3691EA@public.gmane.org>
2008-05-15 13:45 ` Dmitry Torokhov
2008-05-15 17:49 ` Tino Keitel
[not found] ` <20080515174939.GA10881-z7fNteJZwjmqk56C3691EA@public.gmane.org>
2008-05-15 18:35 ` Dmitry Torokhov
2008-05-15 20:59 ` Tino Keitel
2008-05-16 7:19 ` Jiri Kosina
2008-05-16 7:26 ` Tino Keitel
2008-05-16 13:13 ` Dmitry Torokhov
2008-05-16 13:32 ` Tino Keitel
[not found] ` <20080516133234.GA10193-Zv899e0YUSaDCaQdYfVI6sM6rOWSkUom@public.gmane.org>
2008-05-16 13:53 ` Dmitry Torokhov
[not found] ` <20080516095218.ZZRA012-NG0XCrj25/nJrYCpivWRnl5pS2h4L8biXqFh9Ls21Oc@public.gmane.org>
2008-05-16 14:07 ` Tino Keitel
2008-05-15 18:40 ` Greg KH
[not found] ` <20080515184034.GB15231-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2008-05-15 20:59 ` Tino Keitel
[not found] ` <20080515205959.GA11683-z7fNteJZwjmqk56C3691EA@public.gmane.org>
2008-05-15 21:11 ` Greg KH
2008-05-15 23:27 ` Tino Keitel
2008-05-16 2:32 ` Greg KH
2008-05-16 5:44 ` Tino Keitel
[not found] ` <20080514221519.GA6575-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2008-05-15 13:40 ` Tino Keitel
2008-05-15 18:41 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2010-01-20 14:17 Bastien Nocera
2010-01-27 15:40 ` Jiri Kosina
2010-02-01 13:52 ` Bastien Nocera
2010-02-03 15:54 ` Jiri Kosina
2010-02-08 16:32 ` Bastien Nocera
2010-02-10 12:52 ` Jiri Kosina
2010-02-11 18:18 ` Bastien Nocera
2010-02-08 16:32 Bastien Nocera
2010-04-16 16:19 Bastien Nocera
2010-04-17 8:12 ` Dmitry Torokhov
2010-04-17 21:44 ` Bastien Nocera
2010-04-18 19:43 ` Dmitry Torokhov
2010-04-18 19:49 ` Bastien Nocera
2010-04-18 20:19 ` Dmitry Torokhov
2010-04-19 0:31 ` Bastien Nocera
2010-04-19 7:28 ` Dmitry Torokhov
2010-04-19 10:08 ` Bastien Nocera
2010-04-21 6:31 ` Dmitry Torokhov
2010-04-21 14:06 ` Bastien Nocera
2010-04-19 9:22 ` Jiri Kosina
2010-04-19 9:31 ` Bastien Nocera
2010-04-19 10:00 ` Jiri Kosina
2010-04-19 10:14 ` Bastien Nocera
2010-04-19 11:08 ` Jiri Kosina
2010-04-21 20:09 ` Dmitry Torokhov
2010-09-03 16:58 ` Bastien Nocera
2010-04-17 21:45 Bastien Nocera
2010-04-21 13:51 Bastien Nocera
2010-09-10 15:19 Bastien Nocera
2012-11-15 18:13 Bastien Nocera
2012-11-19 15:32 ` Benjamin Tissoires
2012-11-19 15:44 ` Bastien Nocera
2012-11-19 16:01 ` Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080515132108.GA9327@dose.home.local \
--to=tino.keitel@gmx.de \
--cc=dmitry.torokhov@gmail.com \
--cc=greg@kroah.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).