From: Andrew Morton <akpm@linux-foundation.org>
To: Markus Armbruster <armbru@redhat.com>
Cc: jeremy@goop.org, xen-devel@lists.xensource.com,
linux-fbdev-devel@lists.sourceforge.net, adaplas@gmail.com,
dmitry.torokhov@gmail.com, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, mingo@redhat.com,
plc@novell.com, linux-input@vger.kernel.org
Subject: Re: [PATCH 1/5] xen: Enable console tty by default in domU if it's not a dummy
Date: Wed, 21 May 2008 17:26:13 -0700 [thread overview]
Message-ID: <20080521172613.18eb24c4.akpm@linux-foundation.org> (raw)
In-Reply-To: <878wy4m4px.fsf@pike.pond.sub.org>
On Wed, 21 May 2008 10:38:50 +0200
Markus Armbruster <armbru@redhat.com> wrote:
> Without console= arguments on the kernel command line, the first
> console to register becomes enabled and the preferred console (the one
> behind /dev/console). This is normally tty (assuming
> CONFIG_VT_CONSOLE is enabled, which it commonly is).
>
> This is okay as long tty is a useful console. But unless we have the
> PV framebuffer, and it is enabled for this domain, tty0 in domU is
> merely a dummy. In that case, we want the preferred console to be the
> Xen console hvc0, and we want it without having to fiddle with the
> kernel command line. Commit b8c2d3dfbc117dff26058fbac316b8acfc2cb5f7
> did that for us.
>
> Since we now have the PV framebuffer, we want to enable and prefer tty
> again, but only when PVFB is enabled. But even then we still want to
> enable the Xen console as well.
>
> Problem: when tty registers, we can't yet know whether the PVFB is
> enabled. By the time we can know (xenstore is up), the console setup
> game is over.
>
> Solution: enable console tty by default, but keep hvc as the preferred
> console. Change the preferred console to tty when PVFB probes
> successfully, unless we've been given console kernel parameters.
What a stunningly good changelog - I'd buy the tee-shirt.
Ack on the non-xen bits.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
next prev parent reply other threads:[~2008-05-22 0:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-21 8:37 [PATCH 0/5] xen pvfb: Para-virtual framebuffer, keyboard and pointer driver updates Markus Armbruster
2008-05-21 8:38 ` [PATCH 1/5] xen: Enable console tty by default in domU if it's not a dummy Markus Armbruster
2008-05-22 0:26 ` Andrew Morton [this message]
2008-05-21 8:39 ` [PATCH 2/5] xen pvfb: Pointer z-axis (mouse wheel) support Markus Armbruster
2008-05-21 8:40 ` [PATCH 3/5] xen pvfb: Module aliases to support module autoloading Markus Armbruster
2008-05-21 8:40 ` [PATCH 4/5] xen pvfb: Zero unused bytes in events sent to backend Markus Armbruster
2008-05-21 8:40 ` [PATCH 5/5] xen pvfb: Dynamic mode support (screen resizing) Markus Armbruster
2008-05-21 9:09 ` [PATCH 0/5] xen pvfb: Para-virtual framebuffer, keyboard and pointer driver updates Jeremy Fitzhardinge
2008-05-21 9:54 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080521172613.18eb24c4.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adaplas@gmail.com \
--cc=armbru@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jeremy@goop.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=plc@novell.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).