From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: "Pau Oliva Fora (pof)" <pau@eslack.org>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
linux-input@vger.kernel.org
Subject: Re: [PATCH resend] HTC Shift Touchscreen Driver
Date: Tue, 27 May 2008 10:55:06 -0400 [thread overview]
Message-ID: <20080527105118.ZZRA012@mailhub.coreip.homeip.net> (raw)
In-Reply-To: <20080527144603.GA18796@s0.pofhq.net>
Hi Pau,
I have couple more comments...
On Tue, May 27, 2008 at 04:46:03PM +0200, Pau Oliva Fora (pof) wrote:
> +
> +static void htcpen_close(struct input_dev *dev)
> +{
> + free_irq(HTCPEN_IRQ, dev);
No, free_irq() should go into htcpen_remove(). Otherwise if we don't
unload the driver and open the device again we will not have IRQ
handler installed.
> + outb_p(DEVICE_DISABLE, HTCPEN_PORT_INIT);
> +}
> +
> +static int __devinit htcpen_isa_probe(struct device *dev, unsigned int id)
> +{
> + int err;
> + struct input_dev *htcpen_dev;
> +
> + inb_p(HTCPEN_PORT_IRQ_CLEAR);
You should not touch the ports until you resetved them with request
region.
--
Dmitry
next prev parent reply other threads:[~2008-05-27 14:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-27 14:46 [PATCH resend] HTC Shift Touchscreen Driver Pau Oliva Fora (pof)
2008-05-27 14:55 ` Dmitry Torokhov [this message]
2008-05-27 15:50 ` Pau Oliva Fora (pof)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080527105118.ZZRA012@mailhub.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pau@eslack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox