From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Antonio Ospite <ospite@studenti.unina.it>
Cc: linux-input@vger.kernel.org, eric miao <eric.y.miao@gmail.com>
Subject: Re: [PATCH] pxa: Fix some issues with pxa27x_keypad driver v2
Date: Wed, 28 May 2008 11:15:36 -0400 [thread overview]
Message-ID: <20080528111503.ZZRA012@mailhub.coreip.homeip.net> (raw)
In-Reply-To: <20080528171114.ed177b63.ospite@studenti.unina.it>
On Wed, May 28, 2008 at 05:11:14PM +0200, Antonio Ospite wrote:
> On Wed, 28 May 2008 10:31:25 -0400
> Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
>
> > Hi Antonio,
> >
> > On Wed, May 28, 2008 at 04:25:39PM +0200, Antonio Ospite wrote:
> > >
> > > - input_dev->evbit[0] = BIT_MASK(EV_KEY) | BIT_MASK(EV_REP) |
> > > - BIT_MASK(EV_REL);
> > > + input_dev->evbit[0] = BIT_MASK(EV_KEY) | BIT_MASK(EV_REP);
> > > + if (keypad->pdata->rotary0_rel_code || keypad->pdata->rotary1_rel_code)
> > > + input_dev->evbit[0] |= BIT_MASK(EV_REL);
> >
> > Shouldn't this also check pdata->enable_rotaryX?
> >
>
> Yes, maybe.
> Do you prefer a check like this?
>
> if ((keypad->pdata->enable_rotary0 && keypad->pdata->rotary0_rel_code) ||
> (keypad->pdata->enable_rotary1 && keypad->pdata->rotary1_rel_code))
> input_dev->evbit[0] |= BIT_MASK(EV_REL);
>
> Just confirm that and I'll resend a fixed version of the patch.
>
Yep, that should work, thanks.
--
Dmitry
next prev parent reply other threads:[~2008-05-28 15:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-28 14:25 [PATCH] pxa: Fix some issues with pxa27x_keypad driver v2 Antonio Ospite
2008-05-28 14:31 ` Dmitry Torokhov
2008-05-28 15:11 ` Antonio Ospite
2008-05-28 15:15 ` Dmitry Torokhov [this message]
2008-05-28 17:36 ` [PATCH] pxa: Fix some issues with pxa27x_keypad driver v3 Antonio Ospite
2008-05-29 0:37 ` eric miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080528111503.ZZRA012@mailhub.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=eric.y.miao@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=ospite@studenti.unina.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).