From: Andrew Morton <akpm@linux-foundation.org>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: linux-input@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org, carlos@strangeworlds.co.uk
Subject: Re: RESEND: [PATCH 3/3] Misc: Add HP WMI laptop extras driver
Date: Mon, 2 Jun 2008 16:30:37 -0700 [thread overview]
Message-ID: <20080602163037.a7044f68.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080529082356.GE16444@srcf.ucam.org>
On Thu, 29 May 2008 09:23:56 +0100
Matthew Garrett <mjg59@srcf.ucam.org> wrote:
> This driver adds support for reading and configuring certain information
> on modern HP laptops with WMI BIOS interfaces. It supports enabling and
> disabling the ambient light sensor, querying attached displays and hard
> drive temperature, sending events on docking and querying the state of
> the dock and toggling the state of the wifi, bluetooth and wwan hardware
> via rfkill. It also makes the little "(i)" button work on machines that
> send that via WMI rather than via the keyboard controller.
I should upgrade everyone to checkpatch-0.19...
WARNING: consider using strict_strtoul in preference to simple_strtoul
#300: FILE: drivers/misc/hp-wmi.c:244:
+ u32 tmp = simple_strtoul(buf, NULL, 10);
The reason for this is that simple_strtoul(() will treat "42foo" as
valid input (ie: 42). Whereas strict_strtoul() will report an error,
which is neater of us.
next prev parent reply other threads:[~2008-06-02 23:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-23 16:09 [PATCH] Add switch for dock events Matthew Garrett
2008-05-24 1:23 ` Andrew Morton
2008-05-28 13:06 ` [PATCH 1/3] Input: " Matthew Garrett
2008-05-28 13:21 ` [PATCH 2/3] ACPI: Send switch event on " Matthew Garrett
2008-05-28 13:29 ` [PATCH 3/3] Misc: Add HP WMI laptop extras driver Matthew Garrett
2008-05-29 5:42 ` RESEND: " Andrew Morton
2008-05-29 8:07 ` Matthew Garrett
2008-05-29 8:23 ` Matthew Garrett
2008-06-02 23:30 ` Andrew Morton [this message]
2008-06-07 10:00 ` Carlos Corbacho
2008-05-29 5:32 ` RESEND: [PATCH 2/3] ACPI: Send switch event on dock events Andrew Morton
2008-05-29 8:15 ` Matthew Garrett
2008-05-29 8:22 ` Version 2: " Matthew Garrett
2008-06-09 9:48 ` Andrew Morton
2008-05-29 8:20 ` Version 2: [PATCH 1/3] Input: Add switch for " Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080602163037.a7044f68.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=carlos@strangeworlds.co.uk \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).