linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Dmitry Torokhov <dtor@insightbb.com>,
	Jaroslav Kysela <perex@perex.cz>,
	alsa-devel@alsa-project.org, linux-input@vger.kernel.org
Subject: Re: Jack reporting v2
Date: Tue, 3 Jun 2008 16:36:53 +0100	[thread overview]
Message-ID: <20080603153652.GA3245@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <s5h8wxm7ev1.wl%tiwai@suse.de>

On Tue, Jun 03, 2008 at 04:49:38PM +0200, Takashi Iwai wrote:

> Yeah, it looks horrible at a first glance, but it's a known workaround
> for reverse selections...

Indeed - that was the main other solution I'd looked at.  It seemed like
too much splatter in the configuration for the drivers but it's about as
good as it looks like it'll get if simply depending on input isn't going
to be OK.

Looking at all this I'm thinking we may as well leave the jack stuff as
a module - it'd at least make the dependency stuff at runtime slightly
easier and if we're going to put in the effort to support all these
mixes of SND and INPUT it's probably as well to remove the runtime
dependency between ALSA and input if jacks aren't actually in use too.

> Also, sound/jack.h should provide empty inline functions for the case 
> CONFIG_SND_JACK=n.  Then you'll be able to reduce ifdefs in the driver
> codes.

Yeah, probably.  Though from that point of view it might be as well to
cut out the SND_JACK middleman...

  reply	other threads:[~2008-06-03 15:36 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-29 21:09 [PATCH/RFC 1/2] Add jack reporting API for ALSA Mark Brown
2008-05-29 21:09 ` [PATCH/RFC 2/2] Add microphone and headset reporting Mark Brown
2008-05-30  8:15 ` [PATCH/RFC 1/2] Add jack reporting API for ALSA Takashi Iwai
2008-05-30 10:15   ` Mark Brown
2008-06-03 10:40 ` Jack reporting v2 Mark Brown
2008-06-03 10:42   ` [PATCH 1/2] Add jack reporting API for ALSA Mark Brown
2008-06-03 10:42     ` [PATCH 2/2] Add microphone and headset reporting Mark Brown
2008-06-03 14:49   ` Jack reporting v2 Takashi Iwai
2008-06-03 15:36     ` Mark Brown [this message]
2008-06-03 15:17   ` Dmitry Torokhov
2008-06-03 23:38     ` Mark Brown
2008-06-06 14:23       ` Mark Brown
2008-07-01  9:24       ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080603153652.GA3245@rakim.wolfsonmicro.main \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=dtor@insightbb.com \
    --cc=linux-input@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).