From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Oliver Neukum <oliver@neukum.org>
Cc: "Alfred E. Heggestad" <aeh@db.org>, Jiri Kosina <jkosina@suse.cz>,
linux-usb@vger.kernel.org, linux-input@vger.kernel.org,
Henk.Vergonet@gmail.com
Subject: Re: [patch]reliably killing urbs in yealink driver
Date: Thu, 26 Jun 2008 10:26:34 -0400 [thread overview]
Message-ID: <20080626142633.GA16831@anvil.corenet.prv> (raw)
In-Reply-To: <200806261344.32326.oliver@neukum.org>
Hi Oliver,
On Thu, Jun 26, 2008 at 01:44:30PM +0200, Oliver Neukum wrote:
> @@ -809,8 +831,7 @@ static int usb_cleanup(struct yealink_de
> if (yld == NULL)
> return err;
>
> - usb_kill_urb(yld->urb_irq); /* parameter validation in core/urb */
> - usb_kill_urb(yld->urb_ctl); /* parameter validation in core/urb */
> + stop_traffic(yld);
stop_traffic is unneeded here since input core guarantees that close is
called when you unregister and opened device. Do you have the hardware
to test? If not I will fold stop_traffic back into yealink_close
locally.
--
Dmitry
next prev parent reply other threads:[~2008-06-26 14:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-26 11:44 [patch]reliably killing urbs in yealink driver Oliver Neukum
2008-06-26 14:26 ` Dmitry Torokhov [this message]
[not found] ` <20080626142633.GA16831-692KRdr1A+M6QviIW9vzWfIbXMQ5te18@public.gmane.org>
2008-06-26 14:32 ` Oliver Neukum
2008-06-26 17:43 ` Dmitry Torokhov
2008-06-27 12:00 ` Oliver Neukum
2008-06-28 15:11 ` Alfred E. Heggestad
2008-06-30 12:10 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080626142633.GA16831@anvil.corenet.prv \
--to=dmitry.torokhov@gmail.com \
--cc=Henk.Vergonet@gmail.com \
--cc=aeh@db.org \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).