From: Oliver Neukum <oliver@neukum.org>
To: daniel.ritz@gmx.ch, Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Jiri Kosina <jkosina@suse.cz>,
linux-usb@vger.kernel.org, linux-input@vger.kernel.org
Subject: [patch]fix race between disconnect and open in usbtouch
Date: Thu, 26 Jun 2008 15:32:05 +0200 [thread overview]
Message-ID: <200806261532.06544.oliver@neukum.org> (raw)
Hi,
if you kill the URB before you unregister, open can come in between
and resubmit the urb. This patch reverses the order.
Regards
Oliver
Signed-off-by: Oliver Neukum <oneukum@suse.de>
---
--- linux-2.6.26-sierra/drivers/input/touchscreen/usbtouchscreen.c.alt 2008-06-26 15:23:34.000000000 +0200
+++ linux-2.6.26-sierra/drivers/input/touchscreen/usbtouchscreen.c 2008-06-26 15:23:38.000000000 +0200
@@ -973,8 +973,8 @@ static void usbtouch_disconnect(struct u
dbg("%s - usbtouch is initialized, cleaning up", __FUNCTION__);
usb_set_intfdata(intf, NULL);
- usb_kill_urb(usbtouch->irq);
input_unregister_device(usbtouch->input);
+ usb_kill_urb(usbtouch->irq);
usb_free_urb(usbtouch->irq);
usbtouch_free_buffers(interface_to_usbdev(intf), usbtouch);
kfree(usbtouch);
next reply other threads:[~2008-06-26 13:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-26 13:32 Oliver Neukum [this message]
[not found] ` <200806261532.06544.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
2008-06-26 13:41 ` [patch]fix race between disconnect and open in usbtouch Ville Syrjälä
[not found] ` <20080626134110.GE22310-ORSVBvAovxo@public.gmane.org>
2008-06-26 13:49 ` Oliver Neukum
[not found] ` <200806261549.28084.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
2008-06-26 14:30 ` Dmitry Torokhov
2008-06-26 14:35 ` Oliver Neukum
2008-06-26 14:46 ` Alan Stern
2008-06-26 17:41 ` Dmitry Torokhov
[not found] ` <20080626133956.ZZRA012-NG0XCrj25/nJrYCpivWRnl5pS2h4L8biXqFh9Ls21Oc@public.gmane.org>
2008-06-26 17:44 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200806261532.06544.oliver@neukum.org \
--to=oliver@neukum.org \
--cc=daniel.ritz@gmx.ch \
--cc=dmitry.torokhov@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox