From: Grant Likely <grant.likely@secretlab.ca>
To: John Linn <John.Linn@xilinx.com>
Cc: linuxppc-dev@ozlabs.org, Sadanand Mutyala <sadanan@xilinx.com>,
dmitry.torokhov@gmail.com, linux-input@vger.kernel.org
Subject: Re: [PATCH] powerpc: Xilinx: PS2: Added new XPS PS2 driver
Date: Mon, 30 Jun 2008 16:45:27 -0600 [thread overview]
Message-ID: <20080630224526.GA23679@secretlab.ca> (raw)
In-Reply-To: <20080630200015.06E6E1F8054@mail93-va3.bigfish.com>
On Mon, Jun 30, 2008 at 02:00:12PM -0600, John Linn wrote:
> >
> >Since xps2_recv() and xps2_send() are used by the sxps2_* routines and
> >by the irq handler, they should be moved to about them in this file.
> >
>
> OK, keeping them close makes maintenance easier I guess.
>
Oops, there is a typo in my comment:
"... they should be moved to *above* them in this file." 'about' doesn't
make much sense.
g.
prev parent reply other threads:[~2008-06-30 22:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080630142451.516A41D1006C@mail57-sin.bigfish.com>
2008-06-30 17:16 ` [PATCH] powerpc: Xilinx: PS2: Added new XPS PS2 driver Grant Likely
2008-06-30 18:10 ` Dmitry Torokhov
2008-06-30 18:53 ` Grant Likely
2008-06-30 20:00 ` John Linn
2008-06-30 22:45 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080630224526.GA23679@secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=John.Linn@xilinx.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=sadanan@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).