From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-input@vger.kernel.org,
Linux Kernel Development <linux-kernel@vger.kernel.org>,
Linux/m68k <linux-m68k@vger.kernel.org>
Subject: Re: [PATCH] drivers/input/ff-core.c needs <linux/sched.h>
Date: Tue, 1 Jul 2008 08:46:54 -0400 [thread overview]
Message-ID: <20080701084316.ZZRA012@mailhub.coreip.homeip.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0807011300110.21227@anakin>
On Tue, Jul 01, 2008 at 01:55:25PM +0200, Geert Uytterhoeven wrote:
> commit 656acd2bbc4ce7f224de499ee255698701396c48
> Author: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Date: Thu Jun 26 11:30:02 2008 -0400
>
> Input: fix locking in force-feedback core
>
> The newly added event_lock spinlock in the input core disallows sleeping
> and therefore using mutexes in event handlers. Convert force-feedback
> core to rely on event_lock instead of mutex to protect slots allocated
> for fore-feedback effects. The original mutex is still used to serialize
> uploading and erasing of effects.
>
> causes the following regression on m68k:
>
> | linux/drivers/input/ff-core.c: In function 'input_ff_upload':
> | linux/drivers/input/ff-core.c:172: error: dereferencing pointer to incomplete type
> | linux/drivers/input/ff-core.c: In function 'erase_effect':
> | linux/drivers/input/ff-core.c:197: error: dereferencing pointer to incomplete type
> | linux/drivers/input/ff-core.c:204: error: dereferencing pointer to incomplete type
> | make[4]: *** [drivers/input/ff-core.o] Error 1
>
Argh! Sorry about it.
> As the incomplete type is `struct task_struct', including <linux/sched.h> fixes
> it.
Not linux/spinlock.h? I wonder if I need to include linux/spinlock.h and
linux/mutex.h directly from linux/input.h... What is the current
policy on headers - do they need to include everything to be
functional or it is responsibility of the user?
--
Dmitry
next prev parent reply other threads:[~2008-07-01 12:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-01 11:55 [PATCH] drivers/input/ff-core.c needs <linux/sched.h> Geert Uytterhoeven
2008-07-01 12:46 ` Dmitry Torokhov [this message]
2008-07-01 13:05 ` Adrian Bunk
2008-07-01 13:14 ` Geert Uytterhoeven
2008-07-01 13:27 ` Dmitry Torokhov
2008-07-02 20:43 ` Dmitry Torokhov
2008-07-03 1:39 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080701084316.ZZRA012@mailhub.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).