From: Andrew Morton <akpm@linux-foundation.org>
To: David Brownell <david-b@pacbell.net>
Cc: Henrik Rydberg <rydberg@euromail.se>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
dmitry.torokhov@gmail.com, robfitz@273k.net, jikos@jikos.cz,
vojtech@suse.cz, dmonakhov@openvz.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH 001/002] linux-input: bcm5974-0.31: fixed resource leak, removed work struct, device data struct introduced
Date: Tue, 1 Jul 2008 20:38:47 -0700 [thread overview]
Message-ID: <20080701203847.2dae15ba.akpm@linux-foundation.org> (raw)
In-Reply-To: <200807012004.17292.david-b@pacbell.net>
On Tue, 1 Jul 2008 20:04:16 -0700 David Brownell <david-b@pacbell.net> wrote:
> On Tuesday 01 July 2008, Andrew Morton wrote:
> > I dunno what USB driver normally use for their dma memory. __Perhaps
> > dma_alloc_coherent()?
>
> kmalloc() as a rule ...
kmalloc(GFP_DMA)? Hopefully not...
> dma_alloc_coherent() only makes sense if
> the buffer gets reused enough that the dma mapping ops (or as I
> think of them, cache maintainence ops) really hurt.
>
> - Dave
next prev parent reply other threads:[~2008-07-02 3:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-28 11:47 [PATCH 001/002] linux-input: bcm5974-0.31: fixed resource leak, removed work struct, device data struct introduced Henrik Rydberg
2008-07-01 22:59 ` Andrew Morton
[not found] ` <20080701155925.a4c00a8e.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2008-07-02 3:04 ` David Brownell
2008-07-02 3:38 ` Andrew Morton [this message]
[not found] ` <20080701203847.2dae15ba.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2008-07-02 3:53 ` David Brownell
2008-07-02 7:46 ` Henrik Rydberg
2008-07-02 7:53 ` Andrew Morton
[not found] ` <20080702005355.8da89ef7.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2008-07-03 15:09 ` Randy Dunlap
2008-07-03 16:33 ` Henrik Rydberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080701203847.2dae15ba.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=david-b@pacbell.net \
--cc=dmitry.torokhov@gmail.com \
--cc=dmonakhov@openvz.org \
--cc=jikos@jikos.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robfitz@273k.net \
--cc=rydberg@euromail.se \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).