linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: stefan@datenfreihafen.org
Cc: linux-arm-kernel@lists.arm.linux.org.uk,
	linux-input@vger.kernel.org, Daniel Ribeiro <wyrm@openezx.org>
Subject: Re: [Patch 08/10] input: Touchscreen driver for the PCAP
Date: Mon, 7 Jul 2008 16:13:29 -0400	[thread overview]
Message-ID: <20080707161212.ZZRA012@mailhub.coreip.homeip.net> (raw)
In-Reply-To: <20080707184131.286622542@datenfreihafen.org>

Hi Stefan,

On Mon, Jul 07, 2008 at 08:40:08PM +0200, stefan@datenfreihafen.org wrote:
> +
> +	input_dev->evbit[0] = BIT_MASK(EV_KEY) | BIT_MASK(EV_ABS);
> +	input_dev->keybit[BIT_WORD(BTN_TOUCH)] = BIT_MASK(BTN_TOUCH);
> +	input_set_abs_params(input_dev, ABS_X, X_AXIS_MIN, X_AXIS_MAX, 0, 0);
> +	input_set_abs_params(input_dev, ABS_Y, Y_AXIS_MIN, Y_AXIS_MAX, 0, 0);
> +	input_set_abs_params(input_dev, ABS_PRESSURE, PRESSURE_MIN,
> +			     PRESSURE_MAX, 0, 0);
> +
> +	input_register_device(pcap_ts->input);

Please add error handling here, otherwise looks good.

Thanks.

-- 
Dmitry

  reply	other threads:[~2008-07-07 20:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20080707184000.411913919@datenfreihafen.org>
2008-07-07 18:40 ` [Patch 08/10] input: Touchscreen driver for the PCAP stefan
2008-07-07 20:13   ` Dmitry Torokhov [this message]
2008-07-07 20:22     ` Stefan Schmidt
2008-07-08  7:40       ` Eric Miao
2008-07-08 20:24         ` Stefan Schmidt
2008-07-08 20:26     ` Stefan Schmidt
2008-07-10 14:23       ` Dmitry Torokhov
2008-07-11 15:23         ` Stefan Schmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080707161212.ZZRA012@mailhub.coreip.homeip.net \
    --to=dmitry.torokhov@gmail.com \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=linux-input@vger.kernel.org \
    --cc=stefan@datenfreihafen.org \
    --cc=wyrm@openezx.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).