From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH] new driver for SGI volume buttons
Date: Thu, 17 Jul 2008 14:27:47 -0400 [thread overview]
Message-ID: <20080717142640.ZZRA012@mailhub.coreip.homeip.net> (raw)
In-Reply-To: <20080717173835.GB10376@alpha.franken.de>
On Thu, Jul 17, 2008 at 07:38:35PM +0200, Thomas Bogendoerfer wrote:
> On Thu, Jul 17, 2008 at 12:05:11PM -0400, Dmitry Torokhov wrote:
> > On Tue, Jul 15, 2008 at 01:04:36PM +0200, Thomas Bogendoerfer wrote:
> > > This driver adds support for the volume buttons on the front of every
> > > SGI Indy and O2 workstation.
> >
> > Looks very nice. Do you think we could pass a pointer to
> > button_status() in device's platform data and get rid of ifdefs
> > altogether?
>
> it's doable, but would need an extra header file for declaring
> a struct for passing the button_status() function pointer. If
> you think that's worth it, I'll implement it.
>
I think it is OK as is for now. If we ever want to add yet another
button flavor then I would request this change.
Thanks.
--
Dmitry
prev parent reply other threads:[~2008-07-17 18:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-15 11:04 [PATCH] new driver for SGI volume buttons Thomas Bogendoerfer
2008-07-17 16:05 ` Dmitry Torokhov
2008-07-17 17:38 ` Thomas Bogendoerfer
2008-07-17 18:27 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080717142640.ZZRA012@mailhub.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).