From: Paul Mundt <lethal@linux-sh.org>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: Tetsuya Mukawa <mukawa@igel.co.jp>,
linux-input@vger.kernel.org, linux-sh@vger.kernel.org,
dmitry.torokhov@gmail.com, akpm@linux-foundation.org
Subject: Re: [PATCH] sh_keysc: Remove request_mem_region() and release_mem_region()
Date: Sat, 19 Jul 2008 07:48:56 +0900 [thread overview]
Message-ID: <20080718224856.GB19263@linux-sh.org> (raw)
In-Reply-To: <aec7e5c30807180455o75108dc2gb7a22b95d18d251@mail.gmail.com>
On Fri, Jul 18, 2008 at 08:55:04PM +0900, Magnus Damm wrote:
> On Fri, Jul 18, 2008 at 5:38 PM, Tetsuya Mukawa <mukawa@igel.co.jp> wrote:
> > Remove request_mem_region() and release_mem_region() from sh_keysc driver.
> > Those functions can find resource conflict, but it is already checked in
> > platform_device_add().
>
> Yes, the request_mem_region() and release_mem_region() calls are redundant.
>
> > Signed-off-by: Tetsuya Mukawa <mukawa@igel.co.jp>
> Signed-off-by: Magnus Damm <damm@igel.co.jp>
>
> Thanks for the patch! =)
>
Applied, thanks.
prev parent reply other threads:[~2008-07-18 22:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-18 8:38 [PATCH] sh_keysc: Remove request_mem_region() and release_mem_region() Tetsuya Mukawa
2008-07-18 11:55 ` Magnus Damm
2008-07-18 22:48 ` Paul Mundt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080718224856.GB19263@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=akpm@linux-foundation.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mukawa@igel.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).