From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Mundt Subject: Re: [PATCH] sh_keysc: Remove request_mem_region() and release_mem_region() Date: Sat, 19 Jul 2008 07:48:56 +0900 Message-ID: <20080718224856.GB19263@linux-sh.org> References: <20080718083836.29015.8503.sendpatchset@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mta23.gyao.ne.jp ([125.63.38.249]:46767 "EHLO mx.gate01.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752539AbYGRWtR (ORCPT ); Fri, 18 Jul 2008 18:49:17 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Magnus Damm Cc: Tetsuya Mukawa , linux-input@vger.kernel.org, linux-sh@vger.kernel.org, dmitry.torokhov@gmail.com, akpm@linux-foundation.org On Fri, Jul 18, 2008 at 08:55:04PM +0900, Magnus Damm wrote: > On Fri, Jul 18, 2008 at 5:38 PM, Tetsuya Mukawa wrote: > > Remove request_mem_region() and release_mem_region() from sh_keysc driver. > > Those functions can find resource conflict, but it is already checked in > > platform_device_add(). > > Yes, the request_mem_region() and release_mem_region() calls are redundant. > > > Signed-off-by: Tetsuya Mukawa > Signed-off-by: Magnus Damm > > Thanks for the patch! =) > Applied, thanks.