From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: "Liang, Dan" <Dan.Liang@atmel.com>
Cc: linux-input@vger.kernel.org,
linux-arm-kernel@lists.arm.linux.org.uk, linux@maxim.org.za
Subject: Re: [PATCH 1/2] Device driver for Atmel integrated touchscreencontroller
Date: Sat, 19 Jul 2008 00:34:40 -0400 [thread overview]
Message-ID: <20080719043440.GC29551@anvil.corenet.prv> (raw)
In-Reply-To: <0F5F73E36031FD46AD3F2E6948F0C0A02089F8@frimb01.corp.atmel.com>
Hi Dan,
On Tue, Jul 15, 2008 at 12:06:22PM +0200, Liang, Dan wrote:
> Sorry again, the previous [PATCH 1/2] still has some formatting problems.
>
> Now finally I fixed it.
>
> The AT91SAM9RL SoC integrates a Touchscreen Controller which can trigger ADC conversion periodically.
>
Overall looks good, just a couple of comments:
- The device does not seem to support pressure reading so I will drop
ABS_PRESSURE reporting.
- The header file - is it needed? If there are no other users of this
file expected I will fold it into the driver.
Thanks!
--
Dmitry
next prev parent reply other threads:[~2008-07-19 4:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-14 2:04 [PATCH 1/2] Device driver for Atmel integrated touchscreen controller Liang, Dan
2008-07-15 4:52 ` Liang, Dan
2008-07-15 10:06 ` [PATCH 1/2] Device driver for Atmel integrated touchscreencontroller Liang, Dan
2008-07-19 4:34 ` Dmitry Torokhov [this message]
2008-07-21 2:12 ` [PATCH 1/2] Device driver for Atmel integratedtouchscreencontroller Liang, Dan
2008-07-21 3:19 ` Dmitry Torokhov
2008-07-21 9:55 ` [PATCH 1/2] Device driver for Atmelintegratedtouchscreencontroller Liang, Dan
2008-07-21 13:00 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080719043440.GC29551@anvil.corenet.prv \
--to=dmitry.torokhov@gmail.com \
--cc=Dan.Liang@atmel.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-input@vger.kernel.org \
--cc=linux@maxim.org.za \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).