From: Paul Mundt <lethal@linux-sh.org>
To: Adrian McMenamin <adrian@newgolddream.dyndns.info>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
lkml <linux-kernel@vger.kernel.org>,
linux-input <linux-input@vger.kernel.org>,
linux-sh <linux-sh@vger.kernel.org>
Subject: Re: [PATCH] input: Clean up maple keyboard driver
Date: Mon, 21 Jul 2008 08:55:30 +0900 [thread overview]
Message-ID: <20080720235530.GA19854@linux-sh.org> (raw)
In-Reply-To: <1216469879.8959.0.camel@localhost.localdomain>
On Sat, Jul 19, 2008 at 01:17:59PM +0100, Adrian McMenamin wrote:
> On Sat, 2008-07-19 at 07:43 +0900, Paul Mundt wrote:
> > On Sun, Jun 15, 2008 at 08:43:39PM +0100, Adrian McMenamin wrote:
> > > Have a single probe function instead of a probe and a connect function.
> > > Also tidy a comment.
> > > 1 files changed, 33 insertions(+), 48 deletions(-)
> > >
> > >
> > > Signed-off-by: Adrian McMenamin <adrian@mcmen.demon.co.uk>
> >
> > Ok, so I was going to take this through my tree, but it doesn't apply any
> > more. Please send an updated version that can be merged.
>
> What is the problem? Is it just a badly formed patch or has something
> changed elsewhere?
>
> I'll have a look but as I have no issues I'm not sure what is wrong.
>
The problem is it doesnt apply, and the code it is against has also
changed. If you have no issues, you obviously havent tried to apply it.
prev parent reply other threads:[~2008-07-20 23:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-15 19:43 [PATCH] input: Clean up maple keyboard driver Adrian McMenamin
2008-07-18 22:43 ` Paul Mundt
2008-07-19 12:17 ` Adrian McMenamin
2008-07-20 23:55 ` Paul Mundt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080720235530.GA19854@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=adrian@newgolddream.dyndns.info \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).