From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Mundt Subject: Re: [PATCH] input: Clean up maple keyboard driver Date: Mon, 21 Jul 2008 08:55:30 +0900 Message-ID: <20080720235530.GA19854@linux-sh.org> References: <1213559019.22707.12.camel@localhost.localdomain> <20080718224323.GA19263@linux-sh.org> <1216469879.8959.0.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mta23.gyao.ne.jp ([125.63.38.249]:22876 "EHLO mx.gate01.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753797AbYGTXzz (ORCPT ); Sun, 20 Jul 2008 19:55:55 -0400 Content-Disposition: inline In-Reply-To: <1216469879.8959.0.camel@localhost.localdomain> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Adrian McMenamin Cc: Dmitry Torokhov , lkml , linux-input , linux-sh On Sat, Jul 19, 2008 at 01:17:59PM +0100, Adrian McMenamin wrote: > On Sat, 2008-07-19 at 07:43 +0900, Paul Mundt wrote: > > On Sun, Jun 15, 2008 at 08:43:39PM +0100, Adrian McMenamin wrote: > > > Have a single probe function instead of a probe and a connect function. > > > Also tidy a comment. > > > 1 files changed, 33 insertions(+), 48 deletions(-) > > > > > > > > > Signed-off-by: Adrian McMenamin > > > > Ok, so I was going to take this through my tree, but it doesn't apply any > > more. Please send an updated version that can be merged. > > What is the problem? Is it just a badly formed patch or has something > changed elsewhere? > > I'll have a look but as I have no issues I'm not sure what is wrong. > The problem is it doesnt apply, and the code it is against has also changed. If you have no issues, you obviously havent tried to apply it.