linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Arjan van de Ven <arjan@infradead.org>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: Enable WM97xx touchscreen sub-drivers by default
Date: Thu, 24 Jul 2008 13:00:05 -0400	[thread overview]
Message-ID: <20080724170005.GA7081@anvil.corenet.prv> (raw)
In-Reply-To: <20080724142650.GA5234@rakim.wolfsonmicro.main>

On Thu, Jul 24, 2008 at 03:26:51PM +0100, Mark Brown wrote:
> On Thu, Jul 24, 2008 at 06:57:56AM -0700, Arjan van de Ven wrote:
> > Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:
> > 
> > > Currently the support for each WM97xx touchscreen model is compiled
> > > out by default, meaning that the default configuration when the
> 
> > this isn't normally how things are done; Linux is on a "off unless
> > selected or unless it breaks booting" policy nowadays...
> 
> These options only be visible if the user has chosen to build the WM97xx
> touchscreen driver which does the default thing already.  Within the
> context of the driver these options are of the broken boot variety since
> without at least one of them being enabled the driver will do nothing
> except waste resources.
> 
> I really don't think it's sensible for the default configuration of the
> driver to produce something totally non-functional.
> 
> > (and distributions don't follow "default" anyway, so don't worry about
> > that part)
> 
> This change is a direct result of Ubuntu enabling the driver with all
> the controllers compiled out.  This seems like a completely reasonable
> thing for them to do - nothing in Kconfig suggests that it is mandatory
> to enable at least one of the options and the existing default and help
> text both suggest that it should be turned off.

I agree with Mark - since the core driver is disabled by default we
don't burden users who do not want it. However enabling the main
option should produce working driver and people who want to save space
in their custom kernels can disable unneeded sub-options.

Will apply.

-- 
Dmitry

  reply	other threads:[~2008-07-24 17:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-24 13:15 [PATCH] Input: Enable WM97xx touchscreen sub-drivers by default Mark Brown
2008-07-24 13:41 ` Mark Brown
2008-07-24 13:57   ` Arjan van de Ven
2008-07-24 14:26     ` Mark Brown
2008-07-24 17:00       ` Dmitry Torokhov [this message]
2008-07-24 13:44 ` pHilipp Zabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080724170005.GA7081@anvil.corenet.prv \
    --to=dmitry.torokhov@gmail.com \
    --cc=arjan@infradead.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).