* drivers/input/serio/hp_sdc.c: Removed duplicated include
@ 2008-07-25 15:30 Huang Weiyi
2008-07-25 15:52 ` Dmitry Torokhov
0 siblings, 1 reply; 4+ messages in thread
From: Huang Weiyi @ 2008-07-25 15:30 UTC (permalink / raw)
To: dmitry.torokhov, dtor; +Cc: linux-input
Removed duplicated include file <linux/semaphore.h> in
drivers/input/serio/hp_sdc.c.
Signed-off-by: Huang Weiyi <weiyi.huang@gmail.com>
diff --git a/drivers/input/serio/hp_sdc.c b/drivers/input/serio/hp_sdc.c
index aad664d..0d39597 100644
--- a/drivers/input/serio/hp_sdc.c
+++ b/drivers/input/serio/hp_sdc.c
@@ -70,7 +70,6 @@
#include <linux/semaphore.h>
#include <linux/slab.h>
#include <linux/hil.h>
-#include <linux/semaphore.h>
#include <asm/io.h>
#include <asm/system.h>
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: drivers/input/serio/hp_sdc.c: Removed duplicated include
2008-07-25 15:30 drivers/input/serio/hp_sdc.c: Removed duplicated include Huang Weiyi
@ 2008-07-25 15:52 ` Dmitry Torokhov
2008-07-25 16:00 ` Dmitry Torokhov
0 siblings, 1 reply; 4+ messages in thread
From: Dmitry Torokhov @ 2008-07-25 15:52 UTC (permalink / raw)
To: Huang Weiyi; +Cc: linux-input
On Fri, Jul 25, 2008 at 11:30:20PM +0800, Huang Weiyi wrote:
> Removed duplicated include file <linux/semaphore.h> in
> drivers/input/serio/hp_sdc.c.
>
What tree is it against? I don't seem to have teh duplicate.
--
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: drivers/input/serio/hp_sdc.c: Removed duplicated include
2008-07-25 15:52 ` Dmitry Torokhov
@ 2008-07-25 16:00 ` Dmitry Torokhov
2008-07-25 16:19 ` Linus Torvalds
0 siblings, 1 reply; 4+ messages in thread
From: Dmitry Torokhov @ 2008-07-25 16:00 UTC (permalink / raw)
To: Huang Weiyi, Linus Torvalds; +Cc: linux-input
On Fri, Jul 25, 2008 at 11:52:19AM -0400, Dmitry Torokhov wrote:
> On Fri, Jul 25, 2008 at 11:30:20PM +0800, Huang Weiyi wrote:
> > Removed duplicated include file <linux/semaphore.h> in
> > drivers/input/serio/hp_sdc.c.
> >
>
> What tree is it against? I don't seem to have teh duplicate.
>
Ah, I see...
Linus, commit 0f17e4c796e89d1f69f13b653aba60e6ccfb8ae0 is basically a
duplicate of 4933d07531711e399d8d578036aa9fc1be2f9b20, both add
linux/semaphore.h but in 2 slightly different places. Do you want to
just revert the first one or to take a new patch correcting the problem?
--
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: drivers/input/serio/hp_sdc.c: Removed duplicated include
2008-07-25 16:00 ` Dmitry Torokhov
@ 2008-07-25 16:19 ` Linus Torvalds
0 siblings, 0 replies; 4+ messages in thread
From: Linus Torvalds @ 2008-07-25 16:19 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: Huang Weiyi, linux-input
On Fri, 25 Jul 2008, Dmitry Torokhov wrote:
>
> Linus, commit 0f17e4c796e89d1f69f13b653aba60e6ccfb8ae0 is basically a
> duplicate of 4933d07531711e399d8d578036aa9fc1be2f9b20, both add
> linux/semaphore.h but in 2 slightly different places. Do you want to
> just revert the first one or to take a new patch correcting the problem?
I'll revert 4933d07, thanks.
Linus
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-07-25 16:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-25 15:30 drivers/input/serio/hp_sdc.c: Removed duplicated include Huang Weiyi
2008-07-25 15:52 ` Dmitry Torokhov
2008-07-25 16:00 ` Dmitry Torokhov
2008-07-25 16:19 ` Linus Torvalds
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).