Re: [PATCH] bcm5974-0.58: name changes, open/close and suspend/resume serialized

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

On Tue, Jul 29, 2008 at 08:46:13AM +0200, Johannes Berg wrote:
> On Tue, 2008-07-29 at 01:41 -0400, Dmitry Torokhov wrote:
> 
> > > one thing about the drivers/input/mouse/Kconfig patch:
> > > 
> > > The original version contained "select USB", which was later changed
> > > to "depends on USB" by Andrew Morton. I saw it reappear as "select USB"
> > > in your latest patch, and simply considered it a change back, but
> > > maybe it was an oversight?
> > > 
> > 
> > I am of the opinion that it is OK to "select" high-level subsystems that
> > don't have additional dependencies, especially if they are "past" the
> > original driver in menuconfig. I don't really like the idea of forcing
> > users revisiting earlier sub-menus after they selected a new subsystem
> > to see if there are any new options. Plus, if user wants driver for his
> > touchpad he does not really care whether it is PS/2 or USB, [s]he just
> > wants it to work.
> 
> USB tends to have implicit dependencies like the ehci/ohci/uhci
> controller though, so it's not going to work like that anyway starting
> from a minimal config, and all defconfigs probably have USB anyway.
> 
> Therefore, I personally would keep it as "depends on" rather than
> "select". YMMV.
> 

It should work fine I think. The full dependancy of most USB input
devices is:

        depends on USB_ARCH_HAS_HCD
        select USB

You do need to select the host controller, that is correct, but you
don't need to go to USB menu, select HCD, then go back to input menu
(which you already visited) and select your USB input device.

-- 
Dmitry