From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: linux-next: Tree for July 30 Date: Thu, 31 Jul 2008 11:26:54 -0700 Message-ID: <20080731112654.d9620b36.akpm@linux-foundation.org> References: <20080730170635.f737ffe9.sfr@canb.auug.org.au> <20080730231029.9818953c.akpm@linux-foundation.org> <20080731140708.GA11229@core.corenet.prv> <58cb370e0807310836x4a6e3c40rf5c3c8ec8b5caae0@mail.gmail.com> <20080731115301.ZZRA012@mailhub.coreip.homeip.net> <20080731104437.5e5669bc.akpm@linux-foundation.org> <20080731141302.ZZRA012@mailhub.coreip.homeip.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:37584 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752404AbYGaS1D (ORCPT ); Thu, 31 Jul 2008 14:27:03 -0400 In-Reply-To: <20080731141302.ZZRA012@mailhub.coreip.homeip.net> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Dmitry Torokhov Cc: Bartlomiej Zolnierkiewicz , Stephen Rothwell , linux-next@vger.kernel.org, LKML , linux-input@vger.kernel.org On Thu, 31 Jul 2008 14:17:31 -0400 Dmitry Torokhov wrote: > On Thu, Jul 31, 2008 at 10:44:37AM -0700, Andrew Morton wrote: > > On Thu, 31 Jul 2008 11:56:48 -0400 Dmitry Torokhov wrote: > > > > > On Thu, Jul 31, 2008 at 05:36:16PM +0200, Bartlomiej Zolnierkiewicz wrote: > > > > On Thu, Jul 31, 2008 at 4:07 PM, Dmitry Torokhov > > > > wrote: > > > > > On Wed, Jul 30, 2008 at 11:10:29PM -0700, Andrew Morton wrote: > > > > >> On Wed, 30 Jul 2008 17:06:35 +1000 Stephen Rothwell wrote: > > > > >> > > > > >> > I have created today's linux-next tree at > > > > >> > git://git.kernel.org/pub/scm/linux/kernel/git/sfr/linux-next.git > > > > >> > > > > >> The X server broke on my FC8 t61p thinkpad. Mainline is OK. > > > > >> > > > > >> Various information is at http://userweb.kernel.org/~akpm/mo/ > > > > >> > > > > >> I'm suspecting the input layer - my synaptics device seems to have > > > > >> disappeared? See http://userweb.kernel.org/~akpm/mo/Xorg-log-diff.txt > > > > >> > > > > > > > > > > I think this patch should help with Synaptics: > > > > > > > > Which unfortunately doesn't help all people running with older synaptics > > > > user-space after commit 0571c5d20aca71c735222132b02aebddf593045c > > > > ("Input: expand keycode space"). > > > > > > > > Can't this be solved without breaking Xorg on newer kernels running > > > > older synaptics? > > > > > > > > > > No. The X driver is broken. It tells kernel to use buffer bugger than > > > allocated and gets its stack smashed. Tslib has also soma funkiness > > > in the ioctl handling as well... *shrug* > > > > > > We have a couple months to get distros updated... > > > > > > > aaarrrrgggggghhh. I don't think this is practical. This means that > > (for example) FC5 machines (of which I happen to have one) are dead. > > And lots of other older-distro-based systems. > > > > Is there some userspace workaround which doesn't require an X server > > update? > > > > Surely it must be possible to make the kernel contiue to support these > > servers? > > > > Andrew, > > It is not like we broke ABI here. The progam (synaptics driver) had a > grave bug. Older kernels happened to paper over the bug because they > did not fill the whole buffer that was advertised as available. Now > that we have more data to report the bug bit us. What do you want me > to do? Paper over the bug again. When it happens, spit out a loud printk. > Synaptics driver is a small package and takes 2 minutes to recompile. > You don't have to update entire X server with it (in fact I don't think > it is even part of X distribution because it is GPL). What proportion of the X servers out there did we just break? Was the crash I saw due to this? Where would I (Aunt Tillie running FC5) go to find out how to fix my machine up again?