From: Andrew Morton <akpm@linux-foundation.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: torvalds@linux-foundation.org, rjw@sisk.pl, bzolnier@gmail.com,
sfr@canb.auug.org.au, linux-next@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: linux-next: Tree for July 30
Date: Thu, 31 Jul 2008 13:10:56 -0700 [thread overview]
Message-ID: <20080731131056.eecc4826.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080731194207.GA12233@anvil.corenet.prv>
On Thu, 31 Jul 2008 15:42:07 -0400
Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> - return bits_to_user(bits, len, _IOC_SIZE(cmd), p, compat_mode);
> +
> + if ((_IOC_NR(cmd) & EV_MAX) == EV_KEY && buf_len == 0x1ff) {
> + printk(KERN_WARNING
> + "evdev.c(EVIOCGBIT): Detected suspicious "
> + "buffer size 0x1ff, limiting output to 64 "
> + "bytes. Make sure you are not using "
> + "EVIOCGBIT(EV_KEY, KEY_MAX)\n");
> + buf_len = 64;
> + }
If that works then great. But I think the printk could be improved.
Please provide sufficient information so that users (not programmers)
can go off and fix things up without needing to email kernel developers.
One suitable approach would be
printk("see http://userweb.kernel.org/~dtor/read-this.txt")
next prev parent reply other threads:[~2008-07-31 20:13 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080730170635.f737ffe9.sfr@canb.auug.org.au>
2008-07-31 6:10 ` linux-next: Tree for July 30 Andrew Morton
2008-07-31 14:07 ` Dmitry Torokhov
2008-07-31 15:36 ` Bartlomiej Zolnierkiewicz
2008-07-31 15:56 ` Dmitry Torokhov
2008-07-31 17:44 ` Andrew Morton
2008-07-31 18:17 ` Dmitry Torokhov
2008-07-31 18:26 ` Andrew Morton
2008-07-31 18:34 ` Dmitry Torokhov
2008-07-31 18:55 ` Andrew Morton
2008-07-31 19:03 ` Dmitry Torokhov
2008-07-31 19:20 ` Hugh Dickins
2008-07-31 18:48 ` Rafael J. Wysocki
2008-07-31 18:54 ` Dmitry Torokhov
2008-07-31 19:10 ` Linus Torvalds
2008-07-31 19:24 ` Dmitry Torokhov
2008-07-31 19:42 ` Dmitry Torokhov
2008-07-31 20:10 ` Andrew Morton [this message]
2008-08-07 18:11 ` Dmitry Torokhov
2008-08-07 18:50 ` Andrew Morton
2008-08-07 19:06 ` Dmitry Torokhov
2008-08-07 18:55 ` Rafael J. Wysocki
2008-08-01 19:12 ` Linus Torvalds
2008-08-01 19:23 ` Dmitry Torokhov
2008-08-01 19:26 ` Linus Torvalds
2008-07-31 19:44 ` Linus Torvalds
2008-07-31 20:05 ` Dmitry Torokhov
2008-07-31 20:16 ` Linus Torvalds
2008-07-31 20:28 ` Linus Torvalds
2008-07-31 20:39 ` Dmitry Torokhov
2008-07-31 20:28 ` Dmitry Torokhov
2008-07-31 19:13 ` Andrew Morton
2008-07-31 19:57 ` Rafael J. Wysocki
2008-08-04 5:47 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080731131056.eecc4826.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bzolnier@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).