From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: linux-next: Tree for July 30 Date: Thu, 31 Jul 2008 13:10:56 -0700 Message-ID: <20080731131056.eecc4826.akpm@linux-foundation.org> References: <20080730170635.f737ffe9.sfr@canb.auug.org.au> <20080731104437.5e5669bc.akpm@linux-foundation.org> <20080731141302.ZZRA012@mailhub.coreip.homeip.net> <200807312048.57575.rjw@sisk.pl> <20080731145023.ZZRA012@mailhub.coreip.homeip.net> <20080731151625.ZZRA012@mailhub.coreip.homeip.net> <20080731194207.GA12233@anvil.corenet.prv> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:50545 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751083AbYGaUNf (ORCPT ); Thu, 31 Jul 2008 16:13:35 -0400 In-Reply-To: <20080731194207.GA12233@anvil.corenet.prv> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Dmitry Torokhov Cc: torvalds@linux-foundation.org, rjw@sisk.pl, bzolnier@gmail.com, sfr@canb.auug.org.au, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org On Thu, 31 Jul 2008 15:42:07 -0400 Dmitry Torokhov wrote: > - return bits_to_user(bits, len, _IOC_SIZE(cmd), p, compat_mode); > + > + if ((_IOC_NR(cmd) & EV_MAX) == EV_KEY && buf_len == 0x1ff) { > + printk(KERN_WARNING > + "evdev.c(EVIOCGBIT): Detected suspicious " > + "buffer size 0x1ff, limiting output to 64 " > + "bytes. Make sure you are not using " > + "EVIOCGBIT(EV_KEY, KEY_MAX)\n"); > + buf_len = 64; > + } If that works then great. But I think the printk could be improved. Please provide sufficient information so that users (not programmers) can go off and fix things up without needing to email kernel developers. One suitable approach would be printk("see http://userweb.kernel.org/~dtor/read-this.txt")