Re: [PATCH] OLPC: psmouse: touchpad driver

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

On Fri, Aug 01, 2008 at 02:20:04PM -0400, Andres Salomon wrote:
> 
> This adds support for OLPC's touchpad.  It has lots of neat features,
> none of which are enabled because the hardware is too buggy.  Instead,
> we use it like a normal touchpad, but with a number of workarounds in
> place to deal with the frequent hardware spasms.  Humidity changes,
> sweat, tinfoil underwear, plugging in AC, drinks, evil felines.. All
> tend to cause the touchpad to freak out.
> 
> Stuff like this keeps me from getting bored.
> 

Good stuff, thank you. I bet you named the module olpc and gave pregix
hgpk to all the functions to mess with mt feeble brain ;) Maybe we
should rename the module to hgpk as well?

> From psmouse-base, we use psmouse_set_state quite a bit, as well
> as piggy-backing off of kpsmoused_wq; so, this also makes those
> available to protocol extensions.
>

Do you think we should provide assessor functions to deal with
kpsmoused instead of playing with it directly? I was thinking about
starting it on-demand for protocols that may use it and shut it off by
default.

-- 
Dmitry