[PATCH] Make Dell keyboard repeat quirk apply to a wider range of hardware

[PATCH] Make Dell keyboard repeat quirk apply to a wider range of hardware

[Matthew Garrett]

Dell laptops fail to send key up events for several of their special 
keys. There's an existing quirk in the kernel to handle this, but it's 
limited to the Latitude range. This patch extends it to cover all 
portable Dells.

Signed-off-by: Matthew Garrett <mjg@redhat.com>

---
diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c
index b1ce10f..e32c24d 100644
--- a/drivers/input/keyboard/atkbd.c
+++ b/drivers/input/keyboard/atkbd.c
@@ -834,10 +834,10 @@ static void atkbd_disconnect(struct serio *serio)
 }
 
 /*
- * Most special keys (Fn+F?) on Dell Latitudes do not generate release
+ * Most special keys (Fn+F?) on Dell laptops do not generate release
  * events so we have to do it ourselves.
  */
-static void atkbd_latitude_keymap_fixup(struct atkbd *atkbd)
+static void atkbd_dell_laptop_keymap_fixup(struct atkbd *atkbd)
 {
 	const unsigned int forced_release_keys[] = {
 		0x85, 0x86, 0x87, 0x88, 0x89, 0x8a, 0x8b, 0x8f, 0x93,
@@ -1461,13 +1461,13 @@ static int __init atkbd_setup_fixup(const struct dmi_system_id *id)
 
 static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = {
 	{
-		.ident = "Dell Latitude series",
+		.ident = "Dell Laptop",
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
-			DMI_MATCH(DMI_PRODUCT_NAME, "Latitude"),
+			DMI_MATCH(DMI_CHASSIS_TYPE, "8"), /* Portable */
 		},
 		.callback = atkbd_setup_fixup,
-		.driver_data = atkbd_latitude_keymap_fixup,
+		.driver_data = atkbd_dell_laptop_keymap_fixup,
 	},
 	{
 		.ident = "HP 2133",

-- 
Matthew Garrett | mjg59@srcf.ucam.org

Re: [PATCH] Make Dell keyboard repeat quirk apply to a wider range of hardware

[legolas558]

Hello there.

In this kernel bug http://bugzilla.kernel.org/show_bug.cgi?id=9147 we 
are experiencing a problem with Fn keys when ACPI is active.
Maybe this patch will fix bug 9147 as side-effect?

Thank you,
--
  Daniele C.

Matthew Garrett ha scritto:
> Dell laptops fail to send key up events for several of their special 
> keys. There's an existing quirk in the kernel to handle this, but it's 
> limited to the Latitude range. This patch extends it to cover all 
> portable Dells.
>
> Signed-off-by: Matthew Garrett <mjg@redhat.com>
>
> ---
> diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c
> index b1ce10f..e32c24d 100644
> --- a/drivers/input/keyboard/atkbd.c
> +++ b/drivers/input/keyboard/atkbd.c
> @@ -834,10 +834,10 @@ static void atkbd_disconnect(struct serio *serio)
>  }
>  
>  /*
> - * Most special keys (Fn+F?) on Dell Latitudes do not generate release
> + * Most special keys (Fn+F?) on Dell laptops do not generate release
>   * events so we have to do it ourselves.
>   */
> -static void atkbd_latitude_keymap_fixup(struct atkbd *atkbd)
> +static void atkbd_dell_laptop_keymap_fixup(struct atkbd *atkbd)
>  {
>  	const unsigned int forced_release_keys[] = {
>  		0x85, 0x86, 0x87, 0x88, 0x89, 0x8a, 0x8b, 0x8f, 0x93,
> @@ -1461,13 +1461,13 @@ static int __init atkbd_setup_fixup(const struct dmi_system_id *id)
>  
>  static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = {
>  	{
> -		.ident = "Dell Latitude series",
> +		.ident = "Dell Laptop",
>  		.matches = {
>  			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> -			DMI_MATCH(DMI_PRODUCT_NAME, "Latitude"),
> +			DMI_MATCH(DMI_CHASSIS_TYPE, "8"), /* Portable */
>  		},
>  		.callback = atkbd_setup_fixup,
> -		.driver_data = atkbd_latitude_keymap_fixup,
> +		.driver_data = atkbd_dell_laptop_keymap_fixup,
>  	},
>  	{
>  		.ident = "HP 2133",
>
>   

Re: [PATCH] Make Dell keyboard repeat quirk apply to a wider range of hardware

[Matthew Garrett]

On Thu, Aug 14, 2008 at 06:50:30AM +0200, legolas558 wrote:
> Hello there.
> 
> In this kernel bug http://bugzilla.kernel.org/show_bug.cgi?id=9147 we 
> are experiencing a problem with Fn keys when ACPI is active.
> Maybe this patch will fix bug 9147 as side-effect?

No, I think they're unrelated.

-- 
Matthew Garrett | mjg59@srcf.ucam.org

Re: [PATCH] Make Dell keyboard repeat quirk apply to a wider range of hardware

[Dmitry Torokhov]

On Thu, Aug 14, 2008 at 04:32:55AM +0100, Matthew Garrett wrote:
> Dell laptops fail to send key up events for several of their special 
> keys. There's an existing quirk in the kernel to handle this, but it's 
> limited to the Latitude range. This patch extends it to cover all 
> portable Dells.
> 
> Signed-off-by: Matthew Garrett <mjg@redhat.com>
> 

Applied to 'next', thank you Matthew.

-- 
Dmitry