From: Felipe Balbi <felipe.balbi@nokia.com>
To: ext Oliver Neukum <oliver@neukum.org>
Cc: dmitry.torokhov@gmail.com, jkosina@suse.cz,
linux-input@vger.kernel.org, linux-usb@vger.kernel.org,
linux-pm@lists.linux-foundation.org
Subject: Re: [patch]full runtime power management for usbhid
Date: Tue, 26 Aug 2008 12:49:15 +0300 [thread overview]
Message-ID: <20080826094915.GQ20450@gandalf.research.nokia.com> (raw)
In-Reply-To: <200808261139.14410.oliver@neukum.org>
On Tue, Aug 26, 2008 at 11:39:13AM +0200, ext Oliver Neukum wrote:
> --- a/drivers/hid/usbhid/usbhid.h 2008-05-06 13:49:51.000000000 +0200
> +++ b/drivers/hid/usbhid/usbhid.h 2008-05-06 14:58:49.000000000 +0200
> @@ -37,7 +37,10 @@ int usbhid_wait_io(struct hid_device* hi
> void usbhid_close(struct hid_device *hid);
> int usbhid_open(struct hid_device *hid);
> void usbhid_init_reports(struct hid_device *hid);
> -void usbhid_submit_report(struct hid_device *hid, struct hid_report *report, unsigned char dir);
> +void usbhid_submit_report
> +(struct hid_device *hid, struct hid_report *report, unsigned char dir);
void usbhid_submit_report(struct hid_device *hid,
struct hid_report *report, unsigned char dir);
would look better. Matter of taste. ditto below.
> switch (urb->status) {
> case 0: /* success */
> + usbhid_mark_busy(usbhid);
^^^^^^^
you added whitespaces there
--
balbi
next prev parent reply other threads:[~2008-08-26 9:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-26 9:39 [patch]full runtime power management for usbhid Oliver Neukum
2008-08-26 9:49 ` Felipe Balbi [this message]
2008-08-26 14:28 ` [linux-pm] " Pavel Machek
2008-08-26 16:33 ` Oliver Neukum
2008-08-28 7:59 ` Pavel Machek
[not found] ` <20080828075959.GC15474-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2008-08-29 7:10 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080826094915.GQ20450@gandalf.research.nokia.com \
--to=felipe.balbi@nokia.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).