From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Henrik Rydberg <rydberg@euromail.se>
Cc: akpm@osdl.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bcm5974-0.62: Compatibility mode reverted, BTN_TOUCH event added
Date: Tue, 2 Sep 2008 16:15:29 -0400 [thread overview]
Message-ID: <20080902161432.ZZRA012@mailhub.coreip.homeip.net> (raw)
In-Reply-To: <48BD9CA4.7080805@euromail.se>
On Tue, Sep 02, 2008 at 10:05:56PM +0200, Henrik Rydberg wrote:
> @@ -296,6 +297,7 @@ static int report_tp_state(struct bcm5974 *dev, int size)
>
> input_report_abs(input, ABS_PRESSURE, int2bound(&c->p, p));
>
> + input_report_key(input, BTN_TOUCH, p > 0);
Just relying on p will probably make it too sensitive, have you tried
adding hysteresis, like synaptics driver does?
--
Dmitry
next prev parent reply other threads:[~2008-09-02 20:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-02 20:05 [PATCH] bcm5974-0.62: Compatibility mode reverted, BTN_TOUCH event added Henrik Rydberg
2008-09-02 20:15 ` Dmitry Torokhov [this message]
2008-09-03 19:55 ` Henrik Rydberg
2008-09-03 20:02 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080902161432.ZZRA012@mailhub.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).