linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Henrik Rydberg <rydberg@euromail.se>
Cc: akpm@osdl.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] input: mousedev: Emulate right and middle buttons for single-button touchpads
Date: Wed, 10 Sep 2008 11:32:14 -0400	[thread overview]
Message-ID: <20080910153213.GA6940@USFSHXP-002051> (raw)
In-Reply-To: <48C7DF08.4060208@euromail.se>

On Wed, Sep 10, 2008 at 04:51:52PM +0200, Henrik Rydberg wrote:
> Greetings Dmitry,
> 
> > On Fri, Sep 05, 2008 at 03:19:56AM +0200, Henrik Rydberg wrote:
> >> On most linux-based systems, the right and middle buttons are used
> >> extensively. On computers lacking either of those buttons, such as
> >> the Apple Macbooks, emulation is needed. This patch adds emulation
> >> of the missing buttons via two-fingers-and-click and three-fingers-
> >> and-click operations, which has recently become standard, both in
> >> MacOS and in the Xorg synaptics driver.
> >>
> > 
> > The standard way of emulating right and middle button presses for
> > "button-deficient" devices is to use Macintosh emulation
> > (MAC_EMUMOUSEBTN) that works not only for touchpads but for regular mice
> > as well.
> 
> I have a hard time believing that in five years from now, people will
> still consider pressing a key on the keyboard the standard way to
> emulate a right click.

Well, what other options do you have if your device has only one
button and nothing else (i.e. it's a mouse, not a touchpad)? Anyway, I
hope in 5 years distros will switch to pure evdev-based interfaces and
won't use mousedev at all.

> Nevertheless, I can see the point in moving
> away from user-land decisions in the kernel. I will not pursue this one
> further, although it is a rather neat piece of functionality.
> 
> > Overall I don't think we should enhance mousedev for scenarios where
> > proper solution is to install Synaptics X driver. This also goes for
> > your other patch improving tapping in mousedev.
> 
> Regarding the tapping patch; it is addressing the correctness of
> already implemented functionality. I can see nothing wrong with that.
>

My position that since the isssue can be "fixed" by simply installing
the proper X driver I'd rather not include it. Mousedev purpose is to
provide good enough emulation in absence of a native driver and that's
it. Also, the default value would not work well on high-resiolution
devices (like Synaptics) and would require user fiddling with kernel
parameters - not worth it in my opinion.

-- 
Dmitry

  reply	other threads:[~2008-09-10 15:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-05  1:19 [PATCH 2/2] input: mousedev: Emulate right and middle buttons for single-button touchpads Henrik Rydberg
2008-09-10 12:52 ` Dmitry Torokhov
2008-09-10 14:51   ` Henrik Rydberg
2008-09-10 15:32     ` Dmitry Torokhov [this message]
2008-09-10 16:05       ` Henrik Rydberg
2008-09-11  6:31         ` Henrik Rydberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080910153213.GA6940@USFSHXP-002051 \
    --to=dmitry.torokhov@gmail.com \
    --cc=akpm@osdl.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rydberg@euromail.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).