From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Andres Salomon <dilinger@queued.net>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] OLPC: touchpad driver (take 2)
Date: Thu, 11 Sep 2008 08:59:57 -0400 [thread overview]
Message-ID: <20080911085753.ZZRA012@mailhub.coreip.homeip.net> (raw)
In-Reply-To: <20080911010124.79166d64@dev.queued.net>
Hi Andres,
On Thu, Sep 11, 2008 at 01:01:24AM -0400, Andres Salomon wrote:
> @@ -114,7 +115,7 @@ ssize_t psmouse_attr_show_helper(struct device *dev, struct device_attribute *at
> ssize_t psmouse_attr_set_helper(struct device *dev, struct device_attribute *attr,
> const char *buf, size_t count);
>
> -#define PSMOUSE_DEFINE_ATTR(_name, _mode, _data, _show, _set) \
> +#define PSMOUSE_DEFINE_ATTR(_name, _mode, _data, _protected_set, _show, _set) \
> static ssize_t _show(struct psmouse *, void *data, char *); \
> static ssize_t _set(struct psmouse *, void *data, const char *, size_t); \
> static struct psmouse_attribute psmouse_attr_##_name = { \
> @@ -129,6 +130,7 @@ static struct psmouse_attribute psmouse_attr_##_name = { \
> .data = _data, \
> .show = _show, \
> .set = _set, \
> + .protected_set = _protected_set, \
> }
>
I would rather you defined __PSMOUSE_DEFINE_ATTR() with 'protected'
argument and then defined PSMOUSE_DEFINE_ATTR() through underscored
version so that nothing else need to be changed.
--
Dmitry
prev parent reply other threads:[~2008-09-11 13:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-13 19:24 [PATCH 3/3] OLPC: touchpad driver (take 2) Andres Salomon
2008-08-15 3:14 ` Dmitry Torokhov
2008-08-29 6:49 ` Andres Salomon
2008-09-10 13:00 ` Dmitry Torokhov
2008-09-10 21:55 ` Andres Salomon
2008-09-11 5:01 ` Andres Salomon
2008-09-11 5:32 ` Andres Salomon
2008-09-11 13:05 ` Dmitry Torokhov
2008-09-11 14:32 ` Andres Salomon
2008-09-11 18:32 ` Andres Salomon
2008-09-11 18:34 ` Andres Salomon
2008-09-11 12:59 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080911085753.ZZRA012@mailhub.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=dilinger@queued.net \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).