linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Andres Salomon <dilinger@queued.net>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] OLPC: touchpad driver (take 2)
Date: Thu, 11 Sep 2008 09:05:22 -0400	[thread overview]
Message-ID: <20080911090103.ZZRA012@mailhub.coreip.homeip.net> (raw)
In-Reply-To: <20080911013209.3d7c70da@dev.queued.net>

On Thu, Sep 11, 2008 at 01:32:09AM -0400, Andres Salomon wrote:
> 
> And here's the current touchpad driver after updating based upon your
> comments.
> 

Looks good. Care to respin it all thogether based on the attribute
change I requested so I can be sure I'm applying the latest version of
everything? Ummm....

> diff --git a/drivers/input/mouse/Kconfig b/drivers/input/mouse/Kconfig
> index 7bbea09..fff0253 100644
> --- a/drivers/input/mouse/Kconfig
> +++ b/drivers/input/mouse/Kconfig
> @@ -96,6 +96,16 @@ config MOUSE_PS2_TOUCHKIT
>  
>  	  If unsure, say N.
>  
> +config MOUSE_PS2_OLPC
> +	bool "OLPC PS/2 mouse protocol extension"
> +	depends on MOUSE_PS2 && OLPC

Are you sure it shoudl depend on OLPC? It looks like driver should
work on any box with PS/2 port. I understand that only OLPC has the
hardware installed but can this change?

Thanks!

-- 
Dmitry

  reply	other threads:[~2008-09-11 13:05 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-13 19:24 [PATCH 3/3] OLPC: touchpad driver (take 2) Andres Salomon
2008-08-15  3:14 ` Dmitry Torokhov
2008-08-29  6:49   ` Andres Salomon
2008-09-10 13:00     ` Dmitry Torokhov
2008-09-10 21:55   ` Andres Salomon
2008-09-11  5:01     ` Andres Salomon
2008-09-11  5:32       ` Andres Salomon
2008-09-11 13:05         ` Dmitry Torokhov [this message]
2008-09-11 14:32           ` Andres Salomon
2008-09-11 18:32           ` Andres Salomon
2008-09-11 18:34             ` Andres Salomon
2008-09-11 12:59       ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080911090103.ZZRA012@mailhub.coreip.homeip.net \
    --to=dmitry.torokhov@gmail.com \
    --cc=dilinger@queued.net \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).