linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arjan Opmeer <arjan@opmeer.net>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: akpm@linux-foundation.org, linux-input@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] input: Update Elantech touchpad driver to v5 for kernel 2.6.27-rc5-mm1
Date: Fri, 19 Sep 2008 09:05:30 +0200	[thread overview]
Message-ID: <20080919070530.GA7599@adopmeer.homeip.net> (raw)
In-Reply-To: <20080919041727.GB7594@core.corenet.prv>


Hi Dmitry,

(Sorry for calling you Dimitry earlier :)

On Fri, Sep 19, 2008 at 12:17:27AM -0400, Dmitry Torokhov wrote:
> On Sun, Sep 14, 2008 at 05:23:44AM +0200, Arjan Opmeer wrote:
> > 
> > Update the Elantech touchpad driver to v5
> 
> Could you tell me if issues with pressure reporting mentioned in bugzilla
> #8781 have been resolved?

I am not exactly sure what the issue is that is described there.

As far as I know the touchpad does not report pressure (maybe the EeePC
style touchpad does, but I do not have hands on experience with that).
However the Xorg Synaptics driver requires pressure events to work. So I
chose a default pressure value and the driver always toggles between no
pressure and default pressure for no touch and touch respectively. This
seems to work well for all my testers as I have not heard any complaints.

A related issue seems to be that the Ubuntu packaged version of the Xorg
Synaptics driver appears to have a bug where adjusting MaxTapTime doesn't
have any effect. In the absence of true pressure reporting this is the
primary parameter to configure ones personal tapping preference for the
Elantech touchpad. I believe the bug reporter in question wants to set this
value to 0 to disable tapping altogether (although the TouchpadOff option
would be better suited), but because of this bug cannot do so.

So all in all I am not quite sure that this is a problem with the Elantech
driver per se.

> I am about to put the driver in my tree and need to know if I can enable
> it unconditionally or need to mark it experimental.

Well, either is fine with me. Just getting it in the mainline kernel will
give it a broader exposure and more testing I guess.


Arjan

  reply	other threads:[~2008-09-19  7:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-14  3:23 [PATCH] input: Update Elantech touchpad driver to v5 for kernel 2.6.27-rc5-mm1 Arjan Opmeer
2008-09-19  4:17 ` Dmitry Torokhov
2008-09-19  7:05   ` Arjan Opmeer [this message]
2008-10-16  3:05     ` Dmitry Torokhov
2008-10-16  4:29       ` Arjan Opmeer
2008-10-16  4:48         ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080919070530.GA7599@adopmeer.homeip.net \
    --to=arjan@opmeer.net \
    --cc=akpm@linux-foundation.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).